diff mbox

[RFA/testsuite] Remove unused globals in mi-simplerun.exp

Message ID 534D800D.10800@redhat.com
State Committed
Headers

Commit Message

Keith Seitz April 15, 2014, 6:53 p.m. UTC 
  Hi,

I noticed this little cleanup while preparing my big[ger] test suite 
cleanup.

Keith

testsuite/ChangeLog
2014-04-15  Keith Seitz  <keiths@redhat.com>

	* gdb.mi/mi-simplerun.exp (test_breakpoints_creation_and_listing):
	Remove unused globals.
	(test_running_the_program): Likewise.
	(test_controlled_execution): Likewise.
	(test_controlling_breakpoints): Likewise.
	(test_program_termination): Likewise.

Comments

Pedro Alves April 15, 2014, 7:03 p.m. UTC | #1 
On 04/15/2014 07:53 PM, Keith Seitz wrote:
> testsuite/ChangeLog
> 2014-04-15  Keith Seitz  <keiths@redhat.com>
> 
> 	* gdb.mi/mi-simplerun.exp (test_breakpoints_creation_and_listing):
> 	Remove unused globals.
> 	(test_running_the_program): Likewise.
> 	(test_controlled_execution): Likewise.
> 	(test_controlling_breakpoints): Likewise.
> 	(test_program_termination): Likewise.

OK.  Please feel free to push these in as obvious.
Keith Seitz April 15, 2014, 7:28 p.m. UTC | #2 
On 04/15/2014 12:03 PM, Pedro Alves wrote:
> On 04/15/2014 07:53 PM, Keith Seitz wrote:
>> testsuite/ChangeLog
>> 2014-04-15  Keith Seitz  <keiths@redhat.com>
>>
>> 	* gdb.mi/mi-simplerun.exp (test_breakpoints_creation_and_listing):
>> 	Remove unused globals.
>> 	(test_running_the_program): Likewise.
>> 	(test_controlled_execution): Likewise.
>> 	(test_controlling_breakpoints): Likewise.
>> 	(test_program_termination): Likewise.
>
> OK.  Please feel free to push these in as obvious.
>

I've pushed this. Thanks!

I *promise* the next patch will be more useful! :-)

Keith
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.mi/mi-simplerun.exp b/gdb/testsuite/gdb.mi/mi-simplerun.exp
index 7d4c49b..7d5baa6 100644
--- a/gdb/testsuite/gdb.mi/mi-simplerun.exp
+++ b/gdb/testsuite/gdb.mi/mi-simplerun.exp
@@ -45,7 +45,6 @@  mi_gdb_reinitialize_dir $srcdir/$subdir
 mi_gdb_load ${binfile}
 
 proc test_breakpoints_creation_and_listing {} {
-    global mi_gdb_prompt
     global srcfile
     global hex
 
@@ -92,9 +91,6 @@  proc test_breakpoints_creation_and_listing {} {
 }
 
 proc test_running_the_program {} {
-    global mi_gdb_prompt
-    global hex
-
     set line_main_head     [gdb_get_line_number "main ("]
     set line_main_body     [expr $line_main_head + 2]
 
@@ -112,7 +108,6 @@  proc test_running_the_program {} {
 }
 
 proc test_controlled_execution {} {
-    global mi_gdb_prompt
     global hex
 
     set line_callee4_head         [gdb_get_line_number "callee4 ("]
@@ -156,8 +151,6 @@  proc test_controlled_execution {} {
 }
 
 proc test_controlling_breakpoints {} {
-    global mi_gdb_prompt
-
     # Enable, delete, set ignore counts in breakpoints
     # (disable was already tested above)
     # Tests:
@@ -169,8 +162,6 @@  proc test_controlling_breakpoints {} {
 }
 
 proc test_program_termination {} {
-    global mi_gdb_prompt
-
     # Run to completion: normal and forced
     # Tests:
     # -exec-abort