[2/3] rsp: add 'E' to escaped characters
Checks
Context |
Check |
Description |
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_gdb_build--master-arm |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_gdb_check--master-arm |
success
|
Testing passed
|
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 |
success
|
Testing passed
|
Commit Message
Add 'E' to the list of escaped characters when sending/receiving
binary data. This is a preparation for the next patch, to be able to
distinguish an error response from binary data that starts with 'E'.
---
gdbsupport/rsp-low.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
>>>>> Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> writes:
> Add 'E' to the list of escaped characters when sending/receiving
> binary data. This is a preparation for the next patch, to be able to
> distinguish an error response from binary data that starts with 'E'.
While this escaping isn't needed for vFile packets, I suppose it's also
not all that harmful -- just a slight increase in traffic. So I tend to
think this is ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
@@ -171,7 +171,7 @@ bin2hex (const gdb_byte *bin, int count)
static int
needs_escaping (gdb_byte b)
{
- return b == '$' || b == '#' || b == '}' || b == '*';
+ return b == '$' || b == '#' || b == '}' || b == '*' || b == 'E';
}
/* See rsp-low.h. */