diff mbox series

[1/1] gdb, testsuite: Fix return value in gdb.base/foll-fork.exp

Message ID 20240522081408.997133-1-felix.willgerodt@intel.com
State New
Headers
Series [1/1] gdb, testsuite: Fix return value in gdb.base/foll-fork.exp |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 fail Testing failed

Commit Message

Willgerodt, Felix May 22, 2024, 8:14 a.m. UTC 
  In a remote testing setup, I saw this error:

~~~
(gdb) FAIL: gdb.base/foll-fork.exp: check_fork_catchpoints: runto: run to main
ERROR: tcl error sourcing gdb/gdb/testsuite/gdb.base/foll-fork.exp.
ERROR: expected boolean value but got ""
    while executing
"if { ![check_fork_catchpoints] } {
    untested "follow-fork not supported"
    return
}"
    (file "gdb/gdb/testsuite/gdb.base/foll-fork.exp" line 434)
    invoked from within
"source gdb/gdb/testsuite/gdb.base/foll-fork.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source gdb/gdb/testsuite/gdb.base/foll-fork.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name""
Remote debugging from host 172.0.1.3, port 37766
Killing process(es): 1171
Quit
~~~

The actual reason for this were some connection problems. Though the
function check_fork_catchpoints shouldn't return an empty string, especially
as it promises to always return 0 or 1. Fix that.
---
 gdb/testsuite/gdb.base/foll-fork.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Tromey May 22, 2024, 3:24 p.m. UTC | #1 
>>>>> "Felix" == Felix Willgerodt <felix.willgerodt@intel.com> writes:

Felix> The actual reason for this were some connection problems. Though the
Felix> function check_fork_catchpoints shouldn't return an empty string, especially
Felix> as it promises to always return 0 or 1. Fix that.

Thank you.  This is ok.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
Willgerodt, Felix May 23, 2024, 6:23 a.m. UTC | #2 
> >>>>> "Felix" == Felix Willgerodt <felix.willgerodt@intel.com> writes:
> 
> Felix> The actual reason for this were some connection problems. Though the
> Felix> function check_fork_catchpoints shouldn't return an empty string,
> especially
> Felix> as it promises to always return 0 or 1. Fix that.
> 
> Thank you.  This is ok.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thanks, pushed!

Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.base/foll-fork.exp b/gdb/testsuite/gdb.base/foll-fork.exp
index ecf2111d4fd..0d801f004e4 100644
--- a/gdb/testsuite/gdb.base/foll-fork.exp
+++ b/gdb/testsuite/gdb.base/foll-fork.exp
@@ -42,7 +42,7 @@  proc_with_prefix check_fork_catchpoints {} {
   global gdb_prompt
 
   if { ![setup] } {
-      return
+      return 0
   }
 
   # Verify that the system supports "catch fork".