diff mbox series

[v3,PR,symtab/30520,4/4] gdb/symtab: use symbol name matcher for all segments in a qualified name

Message ID 20240506150920.1220092-4-dmitry.neverov@jetbrains.com
State New
Headers
Series [v3,PR,symtab/30520,1/4] gdb/symtab: check name matches before expanding a CU |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Dmitry.Neverov May 6, 2024, 3:09 p.m. UTC 
  ---
 gdb/dwarf2/read.c | 35 +++++++++++++++++++++++++----------
 1 file changed, 25 insertions(+), 10 deletions(-)

Comments

Dmitry.Neverov May 6, 2024, 3:23 p.m. UTC | #1 
I've run tests on x86-64 linux. The only unexpected failure was

FAIL: gdb.base/empty-host-env-vars.exp: env_var_name=HOME: show
index-cache directory

But it doesn't seem to be related to this patch.

--
Dmitry
Tom Tromey May 7, 2024, 5:26 p.m. UTC | #2 
>>>>> "Dmitry" == Dmitry Neverov <dmitry.neverov@jetbrains.com> writes:

Thanks for the patch.

Dmitry>        std::vector<std::string_view> name_vec
Dmitry>  	= lookup_name_without_params.split_name (lang);
Dmitry> -      std::string last_name (name_vec.back ());
Dmitry> -
Dmitry> -      lookup_name_info last_segment_lookup_name (
Dmitry> -	last_name, symbol_name_match_type::FULL, completing, true);
Dmitry> +      std::vector<std::string> name_str_vec (name_vec.begin (), name_vec.end ());

I was going to suggest changing split_name to simply return this vector,
but I'd forgotten that cooked-index.c also uses it.

Dmitry> +      std::vector<lookup_name_info> segment_lookup_names;
Dmitry> +      segment_lookup_names.reserve (name_vec.size ());
Dmitry> +      for (auto &segment_name : name_str_vec)
Dmitry> +	{
Dmitry> +	  segment_lookup_names.emplace_back (segment_name,
Dmitry> +	    symbol_name_match_type::FULL, completing, true);

This should be indented more to line up with "segment_name" from the
previous line.

Otherwise this looks good to me.

Tom
diff mbox series

Patch

diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index f2842f0f581..e8416905163 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -16644,12 +16644,16 @@  cooked_index_functions::expand_symtabs_matching
     {
       std::vector<std::string_view> name_vec
 	= lookup_name_without_params.split_name (lang);
-      std::string last_name (name_vec.back ());
-
-      lookup_name_info last_segment_lookup_name (
-	last_name, symbol_name_match_type::FULL, completing, true);
+      std::vector<std::string> name_str_vec (name_vec.begin (), name_vec.end ());
+      std::vector<lookup_name_info> segment_lookup_names;
+      segment_lookup_names.reserve (name_vec.size ());
+      for (auto &segment_name : name_str_vec)
+	{
+	  segment_lookup_names.emplace_back (segment_name,
+	    symbol_name_match_type::FULL, completing, true);
+	}
 
-      for (const cooked_index_entry *entry : table->find (last_name,
+      for (const cooked_index_entry *entry : table->find (name_str_vec.back (),
 							  completing))
 	{
 	  QUIT;
@@ -16678,13 +16682,24 @@  cooked_index_functions::expand_symtabs_matching
 	    {
 	      /* If we ran out of entries, or if this segment doesn't
 		 match, this did not match.  */
-	      if (parent == nullptr
-		  || strncmp (parent->name, name_vec[i - 1].data (),
-			      name_vec[i - 1].length ()) != 0)
+	      if (parent == nullptr)
 		{
 		  found = false;
 		  break;
 		}
+	      if (parent->lang != language_unknown)
+		{
+		  const language_defn *lang_def = language_def (parent->lang);
+		  symbol_name_matcher_ftype *name_matcher
+		    = lang_def->get_symbol_name_matcher
+		      (segment_lookup_names[i-1]);
+		  if (!name_matcher (parent->canonical,
+				     segment_lookup_names[i-1], nullptr))
+		    {
+		      found = false;
+		      break;
+		    }
+		}
 
 	      parent = parent->get_parent ();
 	    }
@@ -16708,9 +16723,9 @@  cooked_index_functions::expand_symtabs_matching
 		      const language_defn *lang_def = language_def (entry->lang);
 		      symbol_name_matcher_ftype *name_matcher
 			= lang_def->get_symbol_name_matcher
-			  (last_segment_lookup_name);
+			  (segment_lookup_names.back ());
 		      if (!name_matcher (entry->canonical,
-					 last_segment_lookup_name, nullptr))
+					 segment_lookup_names.back (), nullptr))
 			continue;
 		    }
 	      }