diff mbox series

Remove tui_refresh_all

Message ID 20240426161550.1120107-1-tom@tromey.com
State New
Headers
Series Remove tui_refresh_all |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Tom Tromey April 26, 2024, 4:15 p.m. UTC 
  This removes tui_refresh_all.  There is only a single caller,
tui_refresh_all_win, so inlining the code there simplifies gdb at no
cost.
---
 gdb/tui/tui-win.c        |  6 +++++-
 gdb/tui/tui-wingeneral.c | 12 ------------
 gdb/tui/tui-wingeneral.h |  1 -
 3 files changed, 5 insertions(+), 14 deletions(-)
diff mbox series

Patch

diff --git a/gdb/tui/tui-win.c b/gdb/tui/tui-win.c
index ced7e254f50..47e33fb60f4 100644
--- a/gdb/tui/tui-win.c
+++ b/gdb/tui/tui-win.c
@@ -480,7 +480,11 @@  void
 tui_refresh_all_win (void)
 {
   clearok (curscr, TRUE);
-  tui_refresh_all ();
+  for (tui_win_info *win_info : all_tui_windows ())
+    {
+      if (win_info->is_visible ())
+	win_info->refresh_window ();
+    }
 }
 
 void
diff --git a/gdb/tui/tui-wingeneral.c b/gdb/tui/tui-wingeneral.c
index c14ac5a8faf..c56179dc562 100644
--- a/gdb/tui/tui-wingeneral.c
+++ b/gdb/tui/tui-wingeneral.c
@@ -189,15 +189,3 @@  tui_win_info::make_visible (bool visible)
   else
     handle.reset (nullptr);
 }
-
-/* Function to refresh all the windows currently displayed.  */
-
-void
-tui_refresh_all ()
-{
-  for (tui_win_info *win_info : all_tui_windows ())
-    {
-      if (win_info->is_visible ())
-	win_info->refresh_window ();
-    }
-}
diff --git a/gdb/tui/tui-wingeneral.h b/gdb/tui/tui-wingeneral.h
index 6bee433689e..652cef95733 100644
--- a/gdb/tui/tui-wingeneral.h
+++ b/gdb/tui/tui-wingeneral.h
@@ -28,7 +28,6 @@  struct tui_win_info;
 
 extern void tui_unhighlight_win (struct tui_win_info *);
 extern void tui_highlight_win (struct tui_win_info *);
-extern void tui_refresh_all ();
 
 /* An RAII class that suppresses output on construction (calling
    wnoutrefresh on the existing windows), and then flushes the output