diff mbox series

[1/6] gdb: add includes in target-debug.h

Message ID 20240417205426.2030615-1-simon.marchi@polymtl.ca
State New
Headers
Series [1/6] gdb: add includes in target-debug.h |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Simon Marchi April 17, 2024, 8:54 p.m. UTC 
  From: Simon Marchi <simon.marchi@efficios.com>

Editing target-debug.h with clangd shows a bunch of errors.  Add some
includes to fix that (make target-debug.h include what it uses).

Change-Id: I49075a171e6875fa516d6b2ce56b4a03ac7b3376
---
 gdb/target-debug.h | 4 ++++
 1 file changed, 4 insertions(+)


base-commit: 56f4dea207d690fff70a3ccb6fe10ebe1e4697c0

Comments

Tom Tromey April 19, 2024, 7:06 p.m. UTC | #1 
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> From: Simon Marchi <simon.marchi@efficios.com>
Simon> Editing target-debug.h with clangd shows a bunch of errors.  Add some
Simon> includes to fix that (make target-debug.h include what it uses).

I think generally this kind of thing is obvious, unless adding the
include is somehow problematic or weird.

Tom
Simon Marchi April 19, 2024, 7:07 p.m. UTC | #2 
On 2024-04-19 15:06, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> From: Simon Marchi <simon.marchi@efficios.com>
> Simon> Editing target-debug.h with clangd shows a bunch of errors.  Add some
> Simon> includes to fix that (make target-debug.h include what it uses).
> 
> I think generally this kind of thing is obvious, unless adding the
> include is somehow problematic or weird.

Ok, thanks, I'll keep that in mind for the following times (I think
there will be more of these).

Simon
diff mbox series

Patch

diff --git a/gdb/target-debug.h b/gdb/target-debug.h
index 20ba1f73ac53..7f1b6d0bed02 100644
--- a/gdb/target-debug.h
+++ b/gdb/target-debug.h
@@ -38,6 +38,10 @@ 
    more simply done there, and target_xfer_partial additionally
    bypasses the debug target.  */
 
+#include "gdbsupport/x86-xstate.h"
+#include "target.h"
+#include "target/wait.h"
+#include "target/waitstatus.h"
 
 /* Helper macro.  */