Message ID | 20240301134752.1561639-1-hawkinsw@obs.cr |
---|---|
State | New |
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 79E203858D39 for <patchwork@sourceware.org>; Fri, 1 Mar 2024 13:48:37 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) by sourceware.org (Postfix) with ESMTPS id EB49A3858D39 for <gdb-patches@sourceware.org>; Fri, 1 Mar 2024 13:48:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB49A3858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=obs.cr Authentication-Results: sourceware.org; spf=none smtp.mailfrom=obs.cr ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EB49A3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f2b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709300891; cv=none; b=kwdbovGRqZPQ5Q7B6Qip+X8WZRdYmDVZveIYK46Gtbvj5C1TLS31efqp1y9X4rk3EqgqSMloNOTYH0cmLWzo8Wv3D6LJyozKkbErwdm0elWtuAE+rU3QF62EbcRX+Bsm72yCcvvEhnUg9jCwYFy8EEjUujDJwDCCxmgwqT8nFvY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709300891; c=relaxed/simple; bh=WHQJUZ4WiAAyOE+Q+xInl70+a+VYg8sm81DkNcuOxbE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=c4Tl5hDpHdmPQ/9LsufVG20dicqyFpuGABfrTHyqjhs86KB4R8vxuxvfzKePjqMTF6rFb3yFR0GZyCiOR1QTQ/evdpXhXtN/0fE0cXkF6bMBYUXcBp7N05TbvI/g5XTZ4PzQjyNRUKC65ceOiQoH4qmw+/l7QDVfRekhlhK4SWo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qv1-xf2b.google.com with SMTP id 6a1803df08f44-6901a6dca63so12354066d6.0 for <gdb-patches@sourceware.org>; Fri, 01 Mar 2024 05:48:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=obs-cr.20230601.gappssmtp.com; s=20230601; t=1709300880; x=1709905680; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fiI2gPn7svV4ybog80kuExHylwlyS1hT/52zF+3KAEo=; b=BQ3/9IM46W/YiTCNHIt6cfM+bHPvg/nVoVuiSXUOnokpXDKiOwITE+kwMD/D235M+i 40iv/zCB9Wy7qBgQN9NOv0RI/DbT2SZqWloZIwhs5qpkOLZaShrMdP9SzliaIwHzZ0sK bg+tkzO+vjP2B5Aj1Vfcf4wrsO39I+WAf9QUWy125ty68zev7qUK8Uy1FrTcQeCWN4w5 4M6kq78e1pkMilnTMPBcJj6ly2hRtHOjCfb0qkqaBsC3IjzRb3Kn1I6a5OD4Vo1xT8ZK S4EUB6uyqGfLWyeYntT7gISIVWG0GvBzETBQIVXvt8pv6Pb+ZW1cg0Yb2bSpDZx76jNj I1Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709300880; x=1709905680; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fiI2gPn7svV4ybog80kuExHylwlyS1hT/52zF+3KAEo=; b=unj/PgUyDg42HtQcTq4eE3L7TC2g+7oIGsy/VTyQ2ac6R7BysFs37KOZBclK/LUFX8 bcB0gznqoPxUlp0hCgKI+W/UdkG/kwiiBX7ohQxu0sl1Rw1pB7mFqaGdBgRmhv3c9wlp LTGhP9hkyKw/1bDDMBRymp2Td/UMy+fLwjLkizIooBx0UEHhAaqxJKc/q/CDhI2KU4rj pysr0f3tXjhmtpm8F8ajGF71vwHAy0xci0U70A2ABTKYTEiQcGiuJH8YnncAn2K+8fkb QBNgg5eTvgIzzZggihxSvxA3SQo1BQ1HiEmLTeivrWxChAP4e70wLH0S6pevgVtYqovH 18pw== X-Gm-Message-State: AOJu0YwBZqxy1nmqjRmh1dsXL7yv75gSUb0Enl+h77Zhu6uuC/AFK+0Y sxA0U4WSC19q+6JXzpdmGmAzi6MxhnAzqx2ao/yJ6DqCN26nHzGHgRYOZduXHrjDjaIxAZgqiJq R X-Google-Smtp-Source: AGHT+IFCVAsZFd4+SJdGtNH9S8zjznguRN6FGvtQfLVpS0zbaRtqwuOxS6KTlfWn1awvNQ7jePG+EQ== X-Received: by 2002:a05:6214:925:b0:68f:6f11:912b with SMTP id dk5-20020a056214092500b0068f6f11912bmr1726002qvb.21.1709300879794; Fri, 01 Mar 2024 05:47:59 -0800 (PST) Received: from borderland.rhod.uc.edu ([129.137.96.2]) by smtp.gmail.com with ESMTPSA id ol17-20020a0562143d1100b006904e2c9e36sm1376634qvb.116.2024.03.01.05.47.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 05:47:59 -0800 (PST) From: Will Hawkins <hawkinsw@obs.cr> To: gdb-patches@sourceware.org Cc: Will Hawkins <hawkinsw@obs.cr> Subject: [PATCH] gdb/jit: Fix missing word in comment Date: Fri, 1 Mar 2024 08:47:47 -0500 Message-ID: <20240301134752.1561639-1-hawkinsw@obs.cr> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org |
Series |
gdb/jit: Fix missing word in comment
|
|
Checks
Context | Check | Description |
---|---|---|
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 | fail | Patch failed to apply |
linaro-tcwg-bot/tcwg_gdb_build--master-arm | fail | Patch failed to apply |
Commit Message
Will Hawkins
March 1, 2024, 1:47 p.m. UTC
ChangeLog:
* gdb/jit.c: Fix missing word in code comment.
Signed-off-by: Will Hawkins <hawkinsw@obs.cr>
---
Notes:
Sorry that this is such a minor patch. I hope it's not a waste
of people's time. I sincerely appreciate all that every maintainer
does to keep gdb going. I attempted to follow the contributor
guide. Please correct me if I did something wrong. Thank you
again for everything.
gdb/jit.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 3/1/24 08:47, Will Hawkins wrote: > ChangeLog: > > * gdb/jit.c: Fix missing word in code comment. > > Signed-off-by: Will Hawkins <hawkinsw@obs.cr> > --- > > Notes: > Sorry that this is such a minor patch. I hope it's not a waste > of people's time. I sincerely appreciate all that every maintainer > does to keep gdb going. I attempted to follow the contributor > guide. Please correct me if I did something wrong. Thank you > again for everything. It's totally fine to send patches for things like that, as long as they fix actual errors. Note that we don't use ChangeLogs in GDB anymore, so you don't need to write a ChangeLog entry. If you saw a reference to ChangeLogs somewhere in the contribution docs, please let me know so I can adjust it. We don't use Signed-off-by tags (yet at least) to track contributions, but it's harmless to have it there anyway, some people just add it out of habit. For now, we require a copyright assignment for contributions, but since this patch can be considered trivial, it doesn't need one. So I'll just go ahead and push it. Thanks, Simon
On Fri, Mar 1, 2024 at 10:15 AM Simon Marchi <simark@simark.ca> wrote: > > On 3/1/24 08:47, Will Hawkins wrote: > > ChangeLog: > > > > * gdb/jit.c: Fix missing word in code comment. > > > > Signed-off-by: Will Hawkins <hawkinsw@obs.cr> > > --- > > > > Notes: > > Sorry that this is such a minor patch. I hope it's not a waste > > of people's time. I sincerely appreciate all that every maintainer > > does to keep gdb going. I attempted to follow the contributor > > guide. Please correct me if I did something wrong. Thank you > > again for everything. > > It's totally fine to send patches for things like that, as long as they > fix actual errors. > Thank you for your kindness! > Note that we don't use ChangeLogs in GDB anymore, so you don't need to > write a ChangeLog entry. If you saw a reference to ChangeLogs somewhere > in the contribution docs, please let me know so I can adjust it. I think that I "assumed" ChangeLogs were still in use because of the relationship between gdb and binutils (where I just a few days ago submitted a few patches and they do want ChangeLog entries). I am really sorry! > > We don't use Signed-off-by tags (yet at least) to track contributions, > but it's harmless to have it there anyway, some people just add it out > of habit. For now, we require a copyright assignment for contributions, > but since this patch can be considered trivial, it doesn't need one. So > I'll just go ahead and push it. > Absolutely understood and, again, I apologize! I sincerely hope that I can continue to contribute and will absolutely do the assignment if/when that happens. Thank you again! Will > Thanks, > > Simon
diff --git a/gdb/jit.c b/gdb/jit.c index 3ca9cdabf9d..a7fd5c40f9d 100644 --- a/gdb/jit.c +++ b/gdb/jit.c @@ -779,8 +779,8 @@ JITed symbol file is not an object file, ignoring it.\n")); b->printable_name); /* Read the section address information out of the symbol file. Since the - file is generated by the JIT at runtime, it should all of the absolute - addresses that we care about. */ + file is generated by the JIT at runtime, it should contain all of the + absolute addresses that we care about. */ section_addr_info sai; for (sec = nbfd->sections; sec != NULL; sec = sec->next) if ((bfd_section_flags (sec) & (SEC_ALLOC|SEC_LOAD)) != 0)