diff mbox series

Fix crash when calling Frame.static_link

Message ID 20240211122507.1069-1-ssbssa@yahoo.de
State New
Headers
Series Fix crash when calling Frame.static_link |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm warning Patch is already merged
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 warning Patch is already merged

Commit Message

Hannes Domani Feb. 11, 2024, 12:25 p.m. UTC 
  If you try to call Frame.static_link for a frame without debug info,
gdb crashes:
```
Temporary breakpoint 1, 0x000000013f821650 in main ()
(gdb) py print(gdb.selected_frame().static_link())

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.
```

The problem was a missing check if get_frame_block returns nullptr
inside frame_follow_static_link.

With this, it works:
```
Temporary breakpoint 1, 0x000000013f941650 in main ()
(gdb) py print(gdb.selected_frame().static_link())
None
```

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31366
---
 gdb/frame.c                           |  3 +++
 gdb/testsuite/gdb.python/py-frame.exp | 14 ++++++++++++++
 2 files changed, 17 insertions(+)

Comments

Tom Tromey Feb. 11, 2024, 4:25 p.m. UTC | #1 
>>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:

Hannes> The problem was a missing check if get_frame_block returns nullptr
Hannes> inside frame_follow_static_link.

Thank you.  This is ok.
I think this is also ok for the gdb-14 branch.

thanks,
Tom
Hannes Domani Feb. 11, 2024, 4:45 p.m. UTC | #2 
Am Sonntag, 11. Februar 2024 um 17:25:18 MEZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:

> >>>>> "Hannes" == Hannes Domani <ssbssa@yahoo.de> writes:
>
> Hannes> The problem was a missing check if get_frame_block returns nullptr
> Hannes> inside frame_follow_static_link.
>
> Thank you.  This is ok.
> I think this is also ok for the gdb-14 branch.

Pushed to both, thanks.

Note that I also added this:
Approved-By: Tom Tromey <tom@tromey.com>


Hannes.
Tom Tromey Feb. 11, 2024, 5:46 p.m. UTC | #3 
Hannes> Note that I also added this:
Hannes> Approved-By: Tom Tromey <tom@tromey.com>

Thanks, it slipped my mind.

Tom
diff mbox series

Patch

diff --git a/gdb/frame.c b/gdb/frame.c
index fae89cbbc0a..72a34fcfedc 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -3121,6 +3121,9 @@  frame_info_ptr
 frame_follow_static_link (frame_info_ptr frame)
 {
   const block *frame_block = get_frame_block (frame, nullptr);
+  if (frame_block == nullptr)
+    return {};
+
   frame_block = frame_block->function_block ();
 
   const struct dynamic_prop *static_link = frame_block->static_link ();
diff --git a/gdb/testsuite/gdb.python/py-frame.exp b/gdb/testsuite/gdb.python/py-frame.exp
index 016fbacdb49..110ddf24480 100644
--- a/gdb/testsuite/gdb.python/py-frame.exp
+++ b/gdb/testsuite/gdb.python/py-frame.exp
@@ -187,3 +187,17 @@  gdb_test "python print(gdb.selected_frame().language())" "c" \
 gdb_test "python print(gdb.selected_frame().read_register(list()))" \
     ".*Invalid type for register.*" \
     "test Frame.read_register with list"
+
+# Compile again without debug info.
+gdb_exit
+if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile} {}] } {
+    return -1
+}
+
+if {![runto_main]} {
+    return 0
+}
+
+# Test if Frame.static_link works for a frame without debug info.
+gdb_test "python print(gdb.selected_frame().static_link())" "None" \
+    "test Frame.static_link for a frame without debug info"