sim: ppc: workaround uninitialized variable compiler warnings

Message ID 20240109011335.3377-1-vapier@gentoo.org
State New
Headers
Series sim: ppc: workaround uninitialized variable compiler warnings |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 warning Patch is already merged

Commit Message

Mike Frysinger Jan. 9, 2024, 1:13 a.m. UTC
  Some compilers don't understand the semctl API and think it's an input
argument even when it's used as an output, and then complains that it
is being used uninitialized.  Zero it out explicitly to workaround it.
This adds some runtime overhead, but should be fairly minor as it's a
small stack buffer, and shouldn't be that relevant relative to all the
other logic in these functions.
---
 sim/ppc/hw_sem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Patch

diff --git a/sim/ppc/hw_sem.c b/sim/ppc/hw_sem.c
index c43af3b1d9ed..9495b8591b92 100644
--- a/sim/ppc/hw_sem.c
+++ b/sim/ppc/hw_sem.c
@@ -111,7 +111,7 @@  hw_sem_init_data(device *me)
   hw_sem_device *sem = (hw_sem_device*)device_data(me);
   const device_unit *d;
   int status;
-  union semun help;
+  union semun help = {};
 
   /* initialize the properties of the sem */
 
@@ -190,7 +190,7 @@  hw_sem_io_read_buffer(device *me,
   struct sembuf sb;
   int status;
   uint32_t u32;
-  union semun help;
+  union semun help = {};
 
   /* do we need to worry about out of range addresses? */