[PATCH/committed] sim: ppc: igen: fix -G handling

Message ID 20231222020602.10361-1-vapier@gentoo.org
State New
Headers
Series [PATCH/committed] sim: ppc: igen: fix -G handling |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 warning Patch is already merged
linaro-tcwg-bot/tcwg_gdb_build--master-arm warning Patch is already merged

Commit Message

Mike Frysinger Dec. 22, 2023, 2:06 a.m. UTC
  We weren't using the enable_p flag to see whether the option should
be enabled or disabled, and we weren't breaking out when done parsing.
---
 sim/ppc/igen.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
  

Patch

diff --git a/sim/ppc/igen.c b/sim/ppc/igen.c
index 8aa19c757f59..9f642440541e 100644
--- a/sim/ppc/igen.c
+++ b/sim/ppc/igen.c
@@ -439,15 +439,22 @@  main(int argc,
               {
               case '=':
 	        icache_size = atoi (argp + strlen ("gen-icache") + 1);
-	        code |= generate_with_icache;
+		if (enable_p)
+		  code |= generate_with_icache;
+		else
+		  code &= ~generate_with_icache;
                 break;
               case '\0':
-	        code |= generate_with_icache;
+		if (enable_p)
+		  code |= generate_with_icache;
+		else
+		  code &= ~generate_with_icache;
                 break;
               default:
 		error ("Expecting -Ggen-icache or -Ggen-icache=<N>\n");
               }
           }
+	  break;
 	}
     case 'I':
       {