[PATCH/committed] sim: ppc: phb: add missing break to address decoder

Message ID 20231221062142.3958-1-vapier@gentoo.org
State New
Headers
Series [PATCH/committed] sim: ppc: phb: add missing break to address decoder |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 warning Patch is already merged
linaro-tcwg-bot/tcwg_gdb_build--master-arm warning Patch is already merged

Commit Message

Mike Frysinger Dec. 21, 2023, 6:21 a.m. UTC
  I don't know what this emulation does exactly, but it missing a break
statement seems kind of obvious based on the 32-bit case above it.
---
 sim/ppc/hw_phb.c | 1 +
 1 file changed, 1 insertion(+)
  

Patch

diff --git a/sim/ppc/hw_phb.c b/sim/ppc/hw_phb.c
index ec1119ee7d9b..06eb29fc5a77 100644
--- a/sim/ppc/hw_phb.c
+++ b/sim/ppc/hw_phb.c
@@ -652,6 +652,7 @@  hw_phb_unit_decode(device *me,
 	     && val != 0x10 && val != 0x18 && val != 0x20)
       device_error(me, "Register number (0x%lx) invalid in 64bit PCI address %s",
 		   val, unit);
+    break;
   case ss_config_code:
     device_error(me, "internal error");
   }