diff mbox series

[2/2] gdb: use put_frame_register instead of put_frame_register_bytes in pseudo_to_concat_raw

Message ID 20231218200256.28489-2-simon.marchi@efficios.com
State New
Headers
Series [1/2] gdb: remove stale comment in value_assign |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Simon Marchi Dec. 18, 2023, 8:02 p.m. UTC 
  Here, we write single complete registers, we don't need the
functionality of put_frame_register_bytes, use put_frame_register
instead.

Change-Id: I987867a27249db4f792a694b47ecb21c44f64d08
---
 gdb/value.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Comments

Tom Tromey Dec. 19, 2023, 3:06 p.m. UTC | #1 
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:

Simon> Here, we write single complete registers, we don't need the
Simon> functionality of put_frame_register_bytes, use put_frame_register
Simon> instead.

FWIW this makes sense to me.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
Simon Marchi Dec. 19, 2023, 4:12 p.m. UTC | #2 
On 12/19/23 10:06, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
> 
> Simon> Here, we write single complete registers, we don't need the
> Simon> functionality of put_frame_register_bytes, use put_frame_register
> Simon> instead.
> 
> FWIW this makes sense to me.
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom

Thanks, pushed both patches.

Simon
diff mbox series

Patch

diff --git a/gdb/value.c b/gdb/value.c
index bca3fd07425f..7523af142348 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -4123,13 +4123,13 @@  pseudo_to_concat_raw (frame_info_ptr next_frame,
   gdbarch *arch = frame_unwind_arch (next_frame);
 
   int raw_reg_1_size = register_size (arch, raw_reg_1_num);
-  put_frame_register_bytes (next_frame, raw_reg_1_num, 0,
-			    pseudo_buf.slice (src_offset, raw_reg_1_size));
+  put_frame_register (next_frame, raw_reg_1_num,
+		      pseudo_buf.slice (src_offset, raw_reg_1_size));
   src_offset += raw_reg_1_size;
 
   int raw_reg_2_size = register_size (arch, raw_reg_2_num);
-  put_frame_register_bytes (next_frame, raw_reg_2_num, 0,
-			    pseudo_buf.slice (src_offset, raw_reg_2_size));
+  put_frame_register (next_frame, raw_reg_2_num,
+		      pseudo_buf.slice (src_offset, raw_reg_2_size));
   src_offset += raw_reg_2_size;
 
   gdb_assert (src_offset == pseudo_buf.size ());
@@ -4177,18 +4177,18 @@  pseudo_to_concat_raw (frame_info_ptr next_frame,
   gdbarch *arch = frame_unwind_arch (next_frame);
 
   int raw_reg_1_size = register_size (arch, raw_reg_1_num);
-  put_frame_register_bytes (next_frame, raw_reg_1_num, 0,
-			    pseudo_buf.slice (src_offset, raw_reg_1_size));
+  put_frame_register (next_frame, raw_reg_1_num,
+		      pseudo_buf.slice (src_offset, raw_reg_1_size));
   src_offset += raw_reg_1_size;
 
   int raw_reg_2_size = register_size (arch, raw_reg_2_num);
-  put_frame_register_bytes (next_frame, raw_reg_2_num, 0,
-			    pseudo_buf.slice (src_offset, raw_reg_2_size));
+  put_frame_register (next_frame, raw_reg_2_num,
+		      pseudo_buf.slice (src_offset, raw_reg_2_size));
   src_offset += raw_reg_2_size;
 
   int raw_reg_3_size = register_size (arch, raw_reg_3_num);
-  put_frame_register_bytes (next_frame, raw_reg_3_num, 0,
-			    pseudo_buf.slice (src_offset, raw_reg_3_size));
+  put_frame_register (next_frame, raw_reg_3_num,
+		      pseudo_buf.slice (src_offset, raw_reg_3_size));
   src_offset += raw_reg_3_size;
 
   gdb_assert (src_offset == pseudo_buf.size ());