Message ID | 20231210-debug-names-fix-v1-1-a8f6d2525018@tromey.com |
---|---|
State | New |
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4853C3857B93 for <patchwork@sourceware.org>; Sun, 10 Dec 2023 16:45:29 +0000 (GMT) X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 7F129385841B for <gdb-patches@sourceware.org>; Sun, 10 Dec 2023 16:45:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F129385841B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7F129385841B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702226706; cv=none; b=d2anecNCz7dUliw7e0+DTcmlu7RCWL18nPeDbpN8zxwWRzdAswoGq+P+JkSA4nAeC1/wAFnPYj3VECMyAw0wpo+UZWDdzehHuAFnl5mzD6kP4675xNgHoW0k0YEjRrx0EUCR7ludXGGvooG6kOsSA4jNKAzy6yLJIlMIvqPBWZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702226706; c=relaxed/simple; bh=psRm1jIfwYvXFH47SUtoKOFFx1vAexuKEXGQ09Rt6e0=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=FZZFs1A7oZLZFKHP9tQXV1xIL9Zq+8V0AiyUcHKtA3UPieBBNu40wvJaq1PxRUILsKxhCmjEJOtU5B+rfcZ0yJm6uLaN8gJhsNl0UUkOfDcnikFRbRSwJoXRbBkwkz41vTXPyKL2KB8QATUYiFkvA1zyl15SZhzaCo7YjDeq7hQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTPS id ByoGrFk1lhqFdCMvPrTyzN; Sun, 10 Dec 2023 16:45:03 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id CMvOrP0aQ11XZCMvOrYzeq; Sun, 10 Dec 2023 16:45:02 +0000 X-Authority-Analysis: v=2.4 cv=Z+v/oVdA c=1 sm=1 tr=0 ts=6575eb0e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=5y8YgAut4uUOwXUl8TkA:9 a=QEXdDO2ut3YA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=To:In-Reply-To:References:Message-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:Date:From:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3t2d1qBy9t2q3trXAPeq5mo9xdFk6ZYCUE6VgszP8MA=; b=glGJOsoDoff+gM6U8VOzVafjCR iPyngMm3EI1e5cZC1GV7dxFqjz8z1n9abUGquje4Hzp1rM895ZuGcS5SQrnbcWZMO6BTmY5xR3z6x uO5MMZmfpuU2dI+Fs3gyTM0dX; Received: from [198.59.47.65] (port=52394 helo=[192.168.131.83]) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from <tom@tromey.com>) id 1rCMvN-001rpu-2a for gdb-patches@sourceware.org; Sun, 10 Dec 2023 09:45:01 -0700 From: Tom Tromey <tom@tromey.com> Date: Sun, 10 Dec 2023 09:44:50 -0700 Subject: [PATCH 01/17] Refactor 'maint set dwarf synchronous' handling MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20231210-debug-names-fix-v1-1-a8f6d2525018@tromey.com> References: <20231210-debug-names-fix-v1-0-a8f6d2525018@tromey.com> In-Reply-To: <20231210-debug-names-fix-v1-0-a8f6d2525018@tromey.com> To: gdb-patches@sourceware.org X-Mailer: b4 0.12.4 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 198.59.47.65 X-Source-L: No X-Exim-ID: 1rCMvN-001rpu-2a X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.131.83]) [198.59.47.65]:52394 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfLlw10nDFMv6qziMnm7Ox3KW/fGA7x24RofhzSyBOnqciBFPytlwX1bZa1357fxjghS/AwDZHcbnNvhCNGkiU9HI28i8H5E2xI9vzfZyH4dkNHHKLA3B BLFIILTNo3qEl9fwq7XrQFj+9tZDqe0sH3yFIzLByXcl985Kj08wrzUKnNSH/KKLY+w20GP+DEhcCRiG8rYBrRzM5TApJxIvHMk= X-Spam-Status: No, score=-3024.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org |
Series |
Rewrite .debug_names reader and writer
|
|
Commit Message
Tom Tromey
Dec. 10, 2023, 4:44 p.m. UTC
The new .debug_names reader will reuse the background reading infrastructure of the cooked index code. In order to share the handling of 'maint set dwarf synchronous' -- and to avoid having to export this global -- this patch refactors this to be handled directly in dwarf2_initialize_objfile. --- gdb/dwarf2/read.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c index cc940d02cea..dc57af96275 100644 --- a/gdb/dwarf2/read.c +++ b/gdb/dwarf2/read.c @@ -3267,6 +3267,10 @@ dwarf2_initialize_objfile (struct objfile *objfile, global_index_cache.miss (); objfile->qf.push_front (make_cooked_index_funcs (per_objfile)); } + + if (dwarf_synchronous && per_bfd->index_table != nullptr) + per_bfd->index_table->wait_completely (); + return true; } @@ -16828,9 +16832,6 @@ make_cooked_index_funcs (dwarf2_per_objfile *per_objfile) avoids races. */ idx->start_reading (); - if (dwarf_synchronous) - idx->wait_completely (); - return quick_symbol_functions_up (new cooked_index_functions); }