diff mbox series

[13/24] gdb: add value::allocate_register

Message ID	20231201162751.741751-14-simon.marchi@efficios.com
State	New
Headers	DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7502B3858C2C From: Simon Marchi <simon.marchi@efficios.com> To: gdb-patches@sourceware.org Cc: Luis Machado <luis.machado@arm.com>, John Baldwin <jhb@freebsd.org>, "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>, Simon Marchi <simon.marchi@efficios.com>, John Baldwin <jhb@FreeBSD.org> Subject: [PATCH 13/24] gdb: add value::allocate_register Date: Fri, 1 Dec 2023 11:27:26 -0500 Message-ID: <20231201162751.741751-14-simon.marchi@efficios.com> In-Reply-To: <20231201162751.741751-1-simon.marchi@efficios.com> References: <20231201162751.741751-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org
Series	Fix reading and writing pseudo registers in non-current frames \| [00/24] Fix reading and writing pseudo registers in non-current frames [01/24] gdb: don't handle i386 k registers as pseudo registers [02/24] gdb: use reg_buffer_common throughout gdbsupport/common-regcache.h [03/24] gdb: make store_integer take an array_view [04/24] gdb: simplify conditions in regcache::{read, write, raw_collect, raw_supply}_part [05/24] gdb: change regcache interface to use array_view [06/24] gdb: fix bugs in {get,put}_frame_register_bytes [07/24] gdb: make put_frame_register take an array_view [08/24] gdb: change value_of_register and value_of_register_lazy to take the next frame [09/24] gdb: remove frame_register [10/24] gdb: make put_frame_register take the next frame [11/24] gdb: make put_frame_register_bytes take the next frame [12/24] gdb: make get_frame_register_bytes take the next frame [13/24] gdb: add value::allocate_register [14/24] gdb: read pseudo register through frame [15/24] gdb: change parameter name in frame_unwind_register_unsigned declaration [16/24] gdb: rename gdbarch_pseudo_register_write to gdbarch_deprecated_pseudo_register_write [17/24] gdb: add gdbarch_pseudo_register_write that takes a frame [18/24] gdb: migrate i386 and amd64 to the new gdbarch_pseudo_register_write [19/24] gdb: make aarch64_za_offsets_from_regnum return za_offsets [20/24] gdb: add missing raw register read in aarch64_sme_pseudo_register_write [21/24] gdb: migrate aarch64 to new gdbarch_pseudo_register_write [22/24] gdb: migrate arm to gdbarch_pseudo_register_read_value [23/24] gdb: migrate arm to new gdbarch_pseudo_register_write [24/24] gdb/testsuite: add tests for unwinding of pseudo registers

Checks

Context	Check	Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64	success	Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm	success	Testing passed

Commit Message

Simon Marchi Dec. 1, 2023, 4:27 p.m. UTC

  Add value::allocate_register, to facilitate allocating a value
representing a register in a given frame (or rather, in the given
frame's previous frame).  It will be used in a subsequent patch.  I
changed one relatively obvious spot that could use it, to at least
exercise the code path.

Change-Id: Icd4960f5e471a74b657bb3596c88d89679ef3772
Reviewed-By: John Baldwin <jhb@FreeBSD.org>
---
 gdb/regcache.c |  7 ++-----
 gdb/value.c    | 15 +++++++++++++++
 gdb/value.h    |  7 +++++++
 3 files changed, 24 insertions(+), 5 deletions(-)

diff mbox series

Patch

diff --git a/gdb/regcache.c b/gdb/regcache.c
index 19ba353a335c..9b3fd4f060c7 100644
--- a/gdb/regcache.c
+++ b/gdb/regcache.c
@@ -775,11 +775,8 @@  readable_regcache::cooked_read_value (int regnum)
       || (m_has_pseudo && m_register_status[regnum] != REG_UNKNOWN)
       || !gdbarch_pseudo_register_read_value_p (m_descr->gdbarch))
     {
-      struct value *result;
-
-      result = value::allocate (register_type (m_descr->gdbarch, regnum));
-      result->set_lval (lval_register);
-      VALUE_REGNUM (result) = regnum;
+      value *result = value::allocate_register
+	(get_next_frame_sentinel_okay (get_current_frame ()), regnum);
 
       /* It is more efficient in general to do this delegation in this
 	 direction than in the other one, even though the value-based
diff --git a/gdb/value.c b/gdb/value.c
index 1a3985582ba5..99af27b98700 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -959,6 +959,21 @@  value::allocate (struct type *type)
   return allocate (type, true);
 }
 
+/* See value.h  */
+
+struct value *
+value::allocate_register (frame_info_ptr next_frame, int regnum)
+{
+  value *result
+    = value::allocate (register_type (frame_unwind_arch (next_frame), regnum));
+
+  result->set_lval (lval_register);
+  VALUE_REGNUM (result) = regnum;
+  VALUE_NEXT_FRAME_ID (result) = get_frame_id (next_frame);
+
+  return result;
+}
+
 /* Allocate a  value  that has the correct length
    for COUNT repetitions of type TYPE.  */
 
diff --git a/gdb/value.h b/gdb/value.h
index 3f9b35b589bd..2f3b41e26ea4 100644
--- a/gdb/value.h
+++ b/gdb/value.h
@@ -159,6 +159,13 @@  struct value
   /* Allocate a value and its contents for type TYPE.  */
   static struct value *allocate (struct type *type);
 
+  /* Allocate a non-lazy value representing register RENUM in the frame previous
+     to NEXT_FRAME.  The type of the value is found using `register_type`.
+
+     The caller is responsible for filling the value's contents.  */
+  static struct value *allocate_register (frame_info_ptr next_frame,
+					  int regnum);
+
   /* Create a computed lvalue, with type TYPE, function pointers
      FUNCS, and closure CLOSURE.  */
   static struct value *allocate_computed (struct type *type,