[3/4] Remove split_style::UNDERSCORE

Message ID 20231121-ada-lookup-perf-v1-3-1efd2d1dbf65@adacore.com
State New
Headers
Series Improve Ada name lookup performance |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Tom Tromey Nov. 21, 2023, 9:09 p.m. UTC
  The recent changes to the way Ada names are matched means that
split_style::UNDERSCORE is no longer used.  This patch removes it.
---
 gdb/split-name.c | 13 -------------
 gdb/split-name.h |  2 --
 2 files changed, 15 deletions(-)
  

Patch

diff --git a/gdb/split-name.c b/gdb/split-name.c
index 0805cb82700..4ef022cf58e 100644
--- a/gdb/split-name.c
+++ b/gdb/split-name.c
@@ -45,19 +45,6 @@  split_name (const char *name, split_style style)
 	}
       break;
 
-    case split_style::UNDERSCORE:
-      /* Handle the Ada encoded (aka mangled) form here.  */
-      for (const char *iter = strstr (name, "__");
-	   iter != nullptr;
-	   iter = strstr (iter, "__"))
-	{
-	  result.emplace_back (&name[previous_len],
-			       iter - &name[previous_len]);
-	  iter += 2;
-	  previous_len = iter - name;
-	}
-      break;
-
     case split_style::DOT_STYLE:
       /* D and Go-style names.  */
       for (const char *iter = strchr (name, '.');
diff --git a/gdb/split-name.h b/gdb/split-name.h
index ad2862e222d..2674c9b8d27 100644
--- a/gdb/split-name.h
+++ b/gdb/split-name.h
@@ -33,8 +33,6 @@  enum class split_style
   /* Split at ".".  Used by Ada, Go, D.  This has a funny name to work
      around a bug in Bison 2.3, which is used on macOS.  */
   DOT_STYLE,
-  /* Split at "__".  Used by Ada encoded names.  */
-  UNDERSCORE,
 };
 
 /* Split NAME into components at module boundaries.  STYLE indicates