diff mbox series

[2/2] gdb: remove nbsd_{ilp32, lp64}_solib_svr4_fetch_link_map_offsets

Message ID 20230928174752.389177-2-simon.marchi@efficios.com
State New
Headers
Series [1/2] gdb: remove unused imports in solib*.[ch] |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 warning Patch is already merged
linaro-tcwg-bot/tcwg_gdb_build--master-arm warning Patch is already merged
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 warning Patch is already merged

Commit Message

Simon Marchi Sept. 28, 2023, 5:47 p.m. UTC 
  They are unused.

Change-Id: I9b78837d41126ce1957aa1e8b08c82a422f06cbf
---
 gdb/netbsd-tdep.c | 15 ---------------
 gdb/netbsd-tdep.h |  3 ---
 2 files changed, 18 deletions(-)

Comments

John Baldwin Sept. 28, 2023, 6:07 p.m. UTC | #1 
On 9/28/23 6:47 PM, Simon Marchi via Gdb-patches wrote:
> They are unused.
> 
> Change-Id: I9b78837d41126ce1957aa1e8b08c82a422f06cbf
> ---
>   gdb/netbsd-tdep.c | 15 ---------------
>   gdb/netbsd-tdep.h |  3 ---
>   2 files changed, 18 deletions(-)
> 
> diff --git a/gdb/netbsd-tdep.c b/gdb/netbsd-tdep.c
> index ed60200f958b..15a9e2fd7d4e 100644
> --- a/gdb/netbsd-tdep.c
> +++ b/gdb/netbsd-tdep.c
> @@ -44,21 +44,6 @@
>   #define	KINFO_VME_FLAG_GROWS_UP		0x00000010
>   #define	KINFO_VME_FLAG_GROWS_DOWN	0x00000020
>   
> -/* FIXME: kettenis/20060115: We should really eliminate the next two
> -   functions completely.  */
> -
> -struct link_map_offsets *
> -nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void)
> -{
> -  return svr4_ilp32_fetch_link_map_offsets ();
> -}
> -
> -struct link_map_offsets *
> -nbsd_lp64_solib_svr4_fetch_link_map_offsets (void)
> -{
> -  return svr4_lp64_fetch_link_map_offsets ();
> -}
> -
>   int
>   nbsd_pc_in_sigtramp (CORE_ADDR pc, const char *func_name)
>   {
> diff --git a/gdb/netbsd-tdep.h b/gdb/netbsd-tdep.h
> index ab13e628d582..2adf9a751e3b 100644
> --- a/gdb/netbsd-tdep.h
> +++ b/gdb/netbsd-tdep.h
> @@ -20,9 +20,6 @@
>   #ifndef NBSD_TDEP_H
>   #define NBSD_TDEP_H
>   
> -struct link_map_offsets *nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void);
> -struct link_map_offsets *nbsd_lp64_solib_svr4_fetch_link_map_offsets (void);
> -
>   int nbsd_pc_in_sigtramp (CORE_ADDR, const char *);
>   
>   /* NetBSD specific set of ABI-related routines.  */

Both patches seem sensible to me, and the NetBSD one in particular looks right.
Simon Marchi Sept. 28, 2023, 6:24 p.m. UTC | #2 
On 9/28/23 14:07, John Baldwin wrote:
> On 9/28/23 6:47 PM, Simon Marchi via Gdb-patches wrote:
>> They are unused.
>>
>> Change-Id: I9b78837d41126ce1957aa1e8b08c82a422f06cbf
>> ---
>>   gdb/netbsd-tdep.c | 15 ---------------
>>   gdb/netbsd-tdep.h |  3 ---
>>   2 files changed, 18 deletions(-)
>>
>> diff --git a/gdb/netbsd-tdep.c b/gdb/netbsd-tdep.c
>> index ed60200f958b..15a9e2fd7d4e 100644
>> --- a/gdb/netbsd-tdep.c
>> +++ b/gdb/netbsd-tdep.c
>> @@ -44,21 +44,6 @@
>>   #define    KINFO_VME_FLAG_GROWS_UP        0x00000010
>>   #define    KINFO_VME_FLAG_GROWS_DOWN    0x00000020
>>   -/* FIXME: kettenis/20060115: We should really eliminate the next two
>> -   functions completely.  */
>> -
>> -struct link_map_offsets *
>> -nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void)
>> -{
>> -  return svr4_ilp32_fetch_link_map_offsets ();
>> -}
>> -
>> -struct link_map_offsets *
>> -nbsd_lp64_solib_svr4_fetch_link_map_offsets (void)
>> -{
>> -  return svr4_lp64_fetch_link_map_offsets ();
>> -}
>> -
>>   int
>>   nbsd_pc_in_sigtramp (CORE_ADDR pc, const char *func_name)
>>   {
>> diff --git a/gdb/netbsd-tdep.h b/gdb/netbsd-tdep.h
>> index ab13e628d582..2adf9a751e3b 100644
>> --- a/gdb/netbsd-tdep.h
>> +++ b/gdb/netbsd-tdep.h
>> @@ -20,9 +20,6 @@
>>   #ifndef NBSD_TDEP_H
>>   #define NBSD_TDEP_H
>>   -struct link_map_offsets *nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void);
>> -struct link_map_offsets *nbsd_lp64_solib_svr4_fetch_link_map_offsets (void);
>> -
>>   int nbsd_pc_in_sigtramp (CORE_ADDR, const char *);
>>     /* NetBSD specific set of ABI-related routines.  */
> 
> Both patches seem sensible to me, and the NetBSD one in particular looks right.

Thanks, I will push them (they could have maybe been considered
obvious).  Can I add your Reviewed-By?

Simon
John Baldwin Sept. 28, 2023, 9:05 p.m. UTC | #3 
On 9/28/23 7:24 PM, Simon Marchi wrote:
> On 9/28/23 14:07, John Baldwin wrote:
>> On 9/28/23 6:47 PM, Simon Marchi via Gdb-patches wrote:
>>> They are unused.
>>>
>>> Change-Id: I9b78837d41126ce1957aa1e8b08c82a422f06cbf
>>> ---
>>>    gdb/netbsd-tdep.c | 15 ---------------
>>>    gdb/netbsd-tdep.h |  3 ---
>>>    2 files changed, 18 deletions(-)
>>>
>>> diff --git a/gdb/netbsd-tdep.c b/gdb/netbsd-tdep.c
>>> index ed60200f958b..15a9e2fd7d4e 100644
>>> --- a/gdb/netbsd-tdep.c
>>> +++ b/gdb/netbsd-tdep.c
>>> @@ -44,21 +44,6 @@
>>>    #define    KINFO_VME_FLAG_GROWS_UP        0x00000010
>>>    #define    KINFO_VME_FLAG_GROWS_DOWN    0x00000020
>>>    -/* FIXME: kettenis/20060115: We should really eliminate the next two
>>> -   functions completely.  */
>>> -
>>> -struct link_map_offsets *
>>> -nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void)
>>> -{
>>> -  return svr4_ilp32_fetch_link_map_offsets ();
>>> -}
>>> -
>>> -struct link_map_offsets *
>>> -nbsd_lp64_solib_svr4_fetch_link_map_offsets (void)
>>> -{
>>> -  return svr4_lp64_fetch_link_map_offsets ();
>>> -}
>>> -
>>>    int
>>>    nbsd_pc_in_sigtramp (CORE_ADDR pc, const char *func_name)
>>>    {
>>> diff --git a/gdb/netbsd-tdep.h b/gdb/netbsd-tdep.h
>>> index ab13e628d582..2adf9a751e3b 100644
>>> --- a/gdb/netbsd-tdep.h
>>> +++ b/gdb/netbsd-tdep.h
>>> @@ -20,9 +20,6 @@
>>>    #ifndef NBSD_TDEP_H
>>>    #define NBSD_TDEP_H
>>>    -struct link_map_offsets *nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void);
>>> -struct link_map_offsets *nbsd_lp64_solib_svr4_fetch_link_map_offsets (void);
>>> -
>>>    int nbsd_pc_in_sigtramp (CORE_ADDR, const char *);
>>>      /* NetBSD specific set of ABI-related routines.  */
>>
>> Both patches seem sensible to me, and the NetBSD one in particular looks right.
> 
> Thanks, I will push them (they could have maybe been considered
> obvious).  Can I add your Reviewed-By?

Sure.
diff mbox series

Patch

diff --git a/gdb/netbsd-tdep.c b/gdb/netbsd-tdep.c
index ed60200f958b..15a9e2fd7d4e 100644
--- a/gdb/netbsd-tdep.c
+++ b/gdb/netbsd-tdep.c
@@ -44,21 +44,6 @@ 
 #define	KINFO_VME_FLAG_GROWS_UP		0x00000010
 #define	KINFO_VME_FLAG_GROWS_DOWN	0x00000020
 
-/* FIXME: kettenis/20060115: We should really eliminate the next two
-   functions completely.  */
-
-struct link_map_offsets *
-nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void)
-{
-  return svr4_ilp32_fetch_link_map_offsets ();
-}
-
-struct link_map_offsets *
-nbsd_lp64_solib_svr4_fetch_link_map_offsets (void)
-{
-  return svr4_lp64_fetch_link_map_offsets ();
-}
-
 int
 nbsd_pc_in_sigtramp (CORE_ADDR pc, const char *func_name)
 {
diff --git a/gdb/netbsd-tdep.h b/gdb/netbsd-tdep.h
index ab13e628d582..2adf9a751e3b 100644
--- a/gdb/netbsd-tdep.h
+++ b/gdb/netbsd-tdep.h
@@ -20,9 +20,6 @@ 
 #ifndef NBSD_TDEP_H
 #define NBSD_TDEP_H
 
-struct link_map_offsets *nbsd_ilp32_solib_svr4_fetch_link_map_offsets (void);
-struct link_map_offsets *nbsd_lp64_solib_svr4_fetch_link_map_offsets (void);
-
 int nbsd_pc_in_sigtramp (CORE_ADDR, const char *);
 
 /* NetBSD specific set of ABI-related routines.  */