diff mbox series

[v2,7/7] Remove old gdb_bfd_openr_iovec

Message ID 20230918-gdb-bfd-vec-v2-7-162c0e9a2bc9@adacore.com
State New
Headers
Series Rewrite gdb_bfd_openr_iovec to be type-safe |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed

Commit Message

Tom Tromey Sept. 18, 2023, 2:52 p.m. UTC 
  This removes the old gdb_bfd_openr_iovec entirely.  I think any new
code should use the type-safe approach.
---
 gdb/gdb_bfd.c | 25 -------------------------
 gdb/gdb_bfd.h | 18 ------------------
 2 files changed, 43 deletions(-)
diff mbox series

Patch

diff --git a/gdb/gdb_bfd.c b/gdb/gdb_bfd.c
index 2f489a4f210..217753cf914 100644
--- a/gdb/gdb_bfd.c
+++ b/gdb/gdb_bfd.c
@@ -931,31 +931,6 @@  gdb_bfd_openr_iovec (const char *filename, const char *target,
 
 /* See gdb_bfd.h.  */
 
-gdb_bfd_ref_ptr
-gdb_bfd_openr_iovec (const char *filename, const char *target,
-		     void *(*open_func) (struct bfd *nbfd,
-					 void *open_closure),
-		     void *open_closure,
-		     file_ptr (*pread_func) (struct bfd *nbfd,
-					     void *stream,
-					     void *buf,
-					     file_ptr nbytes,
-					     file_ptr offset),
-		     int (*close_func) (struct bfd *nbfd,
-					void *stream),
-		     int (*stat_func) (struct bfd *abfd,
-				       void *stream,
-				       struct stat *sb))
-{
-  bfd *result = bfd_openr_iovec (filename, target,
-				 open_func, open_closure,
-				 pread_func, close_func, stat_func);
-
-  return gdb_bfd_ref_ptr::new_reference (result);
-}
-
-/* See gdb_bfd.h.  */
-
 void
 gdb_bfd_mark_parent (bfd *child, bfd *parent)
 {
diff --git a/gdb/gdb_bfd.h b/gdb/gdb_bfd.h
index ae374f5d7ae..604365b61b1 100644
--- a/gdb/gdb_bfd.h
+++ b/gdb/gdb_bfd.h
@@ -181,24 +181,6 @@  using gdb_iovec_opener_ftype
 gdb_bfd_ref_ptr gdb_bfd_openr_iovec (const char *filename, const char *target,
 				     gdb_iovec_opener_ftype open_fn);
 
-/* A wrapper for bfd_openr_iovec that initializes the gdb-specific
-   reference count.  */
-
-gdb_bfd_ref_ptr gdb_bfd_openr_iovec (const char *filename, const char *target,
-				     void *(*open_func) (struct bfd *nbfd,
-							 void *open_closure),
-				     void *open_closure,
-				     file_ptr (*pread_func) (struct bfd *nbfd,
-							     void *stream,
-							     void *buf,
-							     file_ptr nbytes,
-							     file_ptr offset),
-				     int (*close_func) (struct bfd *nbfd,
-							void *stream),
-				     int (*stat_func) (struct bfd *abfd,
-						       void *stream,
-						       struct stat *sb));
-
 /* A wrapper for bfd_openr_next_archived_file that initializes the
    gdb-specific reference count.  */