diff mbox series

[2/2] gdb: remove interp_supports_command_editing

Message ID 20230906192916.210156-2-simon.marchi@efficios.com
State New
Headers
Series [1/2] gdb: remove interp_pre_command_loop |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed

Commit Message

Simon Marchi Sept. 6, 2023, 7:29 p.m. UTC 
  It is a trivial wrapper around the supports_command_editing method,
remove it.

Change-Id: I0fe3d7dc69601b3b89f82e055f7fe3d4af1becf7
---
 gdb/event-top.c | 4 ++--
 gdb/interps.c   | 8 --------
 gdb/interps.h   | 4 ----
 3 files changed, 2 insertions(+), 14 deletions(-)

Comments

Tom Tromey Sept. 7, 2023, 6:03 p.m. UTC | #1 
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> It is a trivial wrapper around the supports_command_editing method,
Simon> remove it.

Looks good.
Approved-By: Tom Tromey <tom@tromey.com>

Tom
diff mbox series

Patch

diff --git a/gdb/event-top.c b/gdb/event-top.c
index 005ef4b7054d..d1be23bcbe9b 100644
--- a/gdb/event-top.c
+++ b/gdb/event-top.c
@@ -299,8 +299,8 @@  change_line_handler (int editing)
 
   /* Don't try enabling editing if the interpreter doesn't support it
      (e.g., MI).  */
-  if (!interp_supports_command_editing (top_level_interpreter ())
-      || !interp_supports_command_editing (command_interp ()))
+  if (!top_level_interpreter ()->supports_command_editing ()
+      || !command_interp ()->supports_command_editing ())
     return;
 
   if (editing)
diff --git a/gdb/interps.c b/gdb/interps.c
index fa294dfa1a3d..adac98125239 100644
--- a/gdb/interps.c
+++ b/gdb/interps.c
@@ -262,14 +262,6 @@  command_interp (void)
     return current_ui->current_interpreter;
 }
 
-/* See interp.h  */
-
-int
-interp_supports_command_editing (struct interp *interp)
-{
-  return interp->supports_command_editing ();
-}
-
 /* interp_exec - This executes COMMAND_STR in the current 
    interpreter.  */
 
diff --git a/gdb/interps.h b/gdb/interps.h
index 95a885d1b691..287df2c8c810 100644
--- a/gdb/interps.h
+++ b/gdb/interps.h
@@ -257,10 +257,6 @@  extern struct interp *command_interp (void);
 
 extern void clear_interpreter_hooks (void);
 
-/* Returns true if INTERP supports using the readline library; false
-   if it uses GDB's own simplified form of readline.  */
-extern int interp_supports_command_editing (struct interp *interp);
-
 /* List the possible interpreters which could complete the given
    text.  */
 extern void interpreter_completer (struct cmd_list_element *ignore,