Fix "usage" errors for some MI varobj commands

Message ID 20230831180012.211663-1-tromey@adacore.com
State New
Headers
Series Fix "usage" errors for some MI varobj commands |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm warning Patch is already merged

Commit Message

Tom Tromey Aug. 31, 2023, 6 p.m. UTC
  I noticed that the "usage" error for -var-set-frozen mentioned the
wrong command name.  Then I looked through the whole file and found a
couple other spots that didn't mention the command name at all.  This
patch fixes all of these.
---
 gdb/mi/mi-cmd-var.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
  

Comments

Kevin Buettner Aug. 31, 2023, 10:03 p.m. UTC | #1
On Thu, 31 Aug 2023 12:00:12 -0600
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> wrote:

> I noticed that the "usage" error for -var-set-frozen mentioned the
> wrong command name.  Then I looked through the whole file and found a
> couple other spots that didn't mention the command name at all.  This
> patch fixes all of these.

LGTM.

Reviewed-by: Kevin Buettner <kevinb@redhat.com>
  

Patch

diff --git a/gdb/mi/mi-cmd-var.c b/gdb/mi/mi-cmd-var.c
index 095790a36c4..8b4dd6d0c96 100644
--- a/gdb/mi/mi-cmd-var.c
+++ b/gdb/mi/mi-cmd-var.c
@@ -246,7 +246,7 @@  mi_cmd_var_set_visualizer (const char *command, const char *const *argv,
   struct varobj *var;
 
   if (argc != 2)
-    error (_("Usage: NAME VISUALIZER_FUNCTION."));
+    error (_("-var-set-visualizer: Usage: NAME VISUALIZER_FUNCTION."));
 
   var = varobj_get_handle (argv[0]);
 
@@ -263,7 +263,7 @@  mi_cmd_var_set_frozen (const char *command, const char *const *argv, int argc)
   bool frozen;
 
   if (argc != 2)
-    error (_("-var-set-format: Usage: NAME FROZEN_FLAG."));
+    error (_("-var-set-frozen: Usage: NAME FROZEN_FLAG."));
 
   var = varobj_get_handle (argv[0]);
 
@@ -442,7 +442,7 @@  mi_cmd_var_info_path_expression (const char *command, const char *const *argv,
   struct varobj *var;
 
   if (argc != 1)
-    error (_("Usage: NAME."));
+    error (_("-var-info-path-expression: Usage: NAME."));
 
   /* Get varobj handle, if a valid var obj name was specified.  */
   var = varobj_get_handle (argv[0]);