diff mbox series

Unify DW_TAG_typedef case in new_symbol

Message ID 20230830213359.2266370-1-tom@tromey.com
State New
Headers
Series Unify DW_TAG_typedef case in new_symbol |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm warning Patch is already merged

Commit Message

Tom Tromey Aug. 30, 2023, 9:33 p.m. UTC 
  This patch merges the DW_TAG_typedef case in new_symbol with some
other type-related cases.  These all have identical code.
---
 gdb/dwarf2/read.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Comments

Guinevere Larsen Aug. 31, 2023, 8:06 a.m. UTC | #1 
On 30/08/2023 23:33, Tom Tromey wrote:
> This patch merges the DW_TAG_typedef case in new_symbol with some
> other type-related cases.  These all have identical code.
> ---
>   gdb/dwarf2/read.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
> index 5b32089094d..aa3d821552a 100644
> --- a/gdb/dwarf2/read.c
> +++ b/gdb/dwarf2/read.c
> @@ -19376,15 +19376,11 @@ new_symbol (struct die_info *die, struct type *type, struct dwarf2_cu *cu,
>   	      }
>   	  }
>   	  break;
> -	case DW_TAG_typedef:
> -	  sym->set_aclass_index (LOC_TYPEDEF);
> -	  sym->set_domain (VAR_DOMAIN);
> -	  list_to_add = cu->list_in_scope;
> -	  break;
>   	case DW_TAG_unspecified_type:
>   	  if (cu->lang () == language_ada)
>   	    break;
>   	  /* FALLTHROUGH */
> +	case DW_TAG_typedef:
>   	case DW_TAG_array_type:
>   	case DW_TAG_base_type:
>   	case DW_TAG_subrange_type:

Nice reduction of complexity!

Reviewed-By: Guinevere Larsen <blarsen@redhat.com>

Hope some maintainer approves this soon!
Tom Tromey Aug. 31, 2023, 1:40 p.m. UTC | #2 
>>>>> "Guinevere" == Guinevere Larsen <blarsen@redhat.com> writes:

Guinevere> Nice reduction of complexity!

Guinevere> Reviewed-By: Guinevere Larsen <blarsen@redhat.com>

Guinevere> Hope some maintainer approves this soon!

Thanks.  Your review is enough for me, I'm going to check it in.

Tom
diff mbox series

Patch

diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 5b32089094d..aa3d821552a 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -19376,15 +19376,11 @@  new_symbol (struct die_info *die, struct type *type, struct dwarf2_cu *cu,
 	      }
 	  }
 	  break;
-	case DW_TAG_typedef:
-	  sym->set_aclass_index (LOC_TYPEDEF);
-	  sym->set_domain (VAR_DOMAIN);
-	  list_to_add = cu->list_in_scope;
-	  break;
 	case DW_TAG_unspecified_type:
 	  if (cu->lang () == language_ada)
 	    break;
 	  /* FALLTHROUGH */
+	case DW_TAG_typedef:
 	case DW_TAG_array_type:
 	case DW_TAG_base_type:
 	case DW_TAG_subrange_type: