diff mbox series

[v2,1/2] Reset note name of NT_RISCV_CSR to "GDB" to be consistent with the intent described in commit db6092f3aec43ea4d10efc5ff74274f04cdc0ad6

Message ID 20230810221122.1155980-2-greg.savin@sifive.com
State New
Headers
Series [v2,1/2] Reset note name of NT_RISCV_CSR to "GDB" to be consistent with the intent described in commit db6092f3aec43ea4d10efc5ff74274f04cdc0ad6 |

Checks

Context Check Description
linaro-tcwg-bot/tcwg_gdb_check--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-aarch64 success Testing passed
linaro-tcwg-bot/tcwg_gdb_build--master-arm success Testing passed
linaro-tcwg-bot/tcwg_gdb_check--master-arm success Testing passed

Commit Message

Greg Savin Aug. 10, 2023, 10:11 p.m. UTC 
  ---
 include/elf/common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Burgess Aug. 11, 2023, 12:23 p.m. UTC | #1 
Greg Savin via Binutils <binutils@sourceware.org> writes:

> ---
>  include/elf/common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/elf/common.h b/include/elf/common.h
> index ffa6b60bd2b..e7eede23a07 100644
> --- a/include/elf/common.h
> +++ b/include/elf/common.h
> @@ -714,7 +714,7 @@
>  #define NT_LARCH_LBT    0xa04		/* LoongArch Binary Translation registers */
>  					/*   note name must be "CORE".  */
>  #define NT_RISCV_CSR    0x900		/* RISC-V Control and Status Registers */
> -					/*   note name must be "LINUX".  */
> +					/*   note name must be "GDB".  */

I'm not a binutils maintainer, so can't approve this, but did originally
add NT_RISCV_CSR.

FWIW, this change LGTM.

Thanks,
Andrew



>  #define NT_SIGINFO	0x53494749	/* Fields of siginfo_t.  */
>  #define NT_FILE		0x46494c45	/* Description of mapped files.  */
>  
> -- 
> 2.25.1
diff mbox series

Patch

diff --git a/include/elf/common.h b/include/elf/common.h
index ffa6b60bd2b..e7eede23a07 100644
--- a/include/elf/common.h
+++ b/include/elf/common.h
@@ -714,7 +714,7 @@ 
 #define NT_LARCH_LBT    0xa04		/* LoongArch Binary Translation registers */
 					/*   note name must be "CORE".  */
 #define NT_RISCV_CSR    0x900		/* RISC-V Control and Status Registers */
-					/*   note name must be "LINUX".  */
+					/*   note name must be "GDB".  */
 #define NT_SIGINFO	0x53494749	/* Fields of siginfo_t.  */
 #define NT_FILE		0x46494c45	/* Description of mapped files.  */