Message ID | 20230313180100.2728620-2-christina.schimpe@intel.com |
---|---|
State | New |
Headers |
Return-Path: <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C9D783858D32 for <patchwork@sourceware.org>; Mon, 13 Mar 2023 18:01:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C9D783858D32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1678730510; bh=nrPE7aHTxdvwfWODFwSz44FOK3SND0MHYfykcHGNitY=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=OTMOaYSXqebqccfM6Qy+m/Dph8u702KGSqDMqRYPvL8x7uJGoouoePm8KR8TcIO9M KHXo8P6md6lhFuiLQFqlOODiK8vh5O+nU0O7Zd9p6uiAuSnbE/LklUKTHV3tXzN+rm 3OXf8KgHN66zUB9Bbkv1YUZ+RiM8+1EgFKiiBI5Q= X-Original-To: gdb-patches@sourceware.org Delivered-To: gdb-patches@sourceware.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by sourceware.org (Postfix) with ESMTPS id AD1193858D32 for <gdb-patches@sourceware.org>; Mon, 13 Mar 2023 18:01:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AD1193858D32 X-IronPort-AV: E=McAfee;i="6500,9779,10648"; a="338766163" X-IronPort-AV: E=Sophos;i="5.98,257,1673942400"; d="scan'208";a="338766163" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2023 11:01:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10648"; a="671994111" X-IronPort-AV: E=Sophos;i="5.98,257,1673942400"; d="scan'208";a="671994111" Received: from labpc2315.iul.intel.com (HELO localhost) ([172.28.50.57]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2023 11:01:26 -0700 To: gdb-patches@sourceware.org Cc: Christina Schimpe <christina.schimpe@intel.com> Subject: [PATCH 1/1] gdb, infcmd: remove redundant ERROR_NO_INFERIOR in continue_command Date: Mon, 13 Mar 2023 19:01:00 +0100 Message-Id: <20230313180100.2728620-2-christina.schimpe@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230313180100.2728620-1-christina.schimpe@intel.com> References: <20230313180100.2728620-1-christina.schimpe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>, <mailto:gdb-patches-request@sourceware.org?subject=subscribe> From: Christina Schimpe via Gdb-patches <gdb-patches@sourceware.org> Reply-To: Christina Schimpe <christina.schimpe@intel.com> Errors-To: gdb-patches-bounces+patchwork=sourceware.org@sourceware.org Sender: "Gdb-patches" <gdb-patches-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
Remove redundant ERROR_NO_INFERIOR in continue_command
|
|
Commit Message
Schimpe, Christina
March 13, 2023, 6:01 p.m. UTC
From: Nils-Christian Kempke <nils-christian.kempke@intel.com>
The ERROR_NO_INFERIOR macro is already called at the beginning of the
function. Since target/inferior are not switched in-between, the second
call to it is redundant.
Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com>
---
gdb/infcmd.c | 1 -
1 file changed, 1 deletion(-)
Comments
On Mon, Mar 13, 2023 at 7:01 PM Christina Schimpe via Gdb-patches < gdb-patches@sourceware.org> wrote: > From: Nils-Christian Kempke <nils-christian.kempke@intel.com> > > The ERROR_NO_INFERIOR macro is already called at the beginning of the > function. Since target/inferior are not switched in-between, the second > call to it is redundant. > > Co-Authored-By: Christina Schimpe <christina.schimpe@intel.com> > --- > gdb/infcmd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gdb/infcmd.c b/gdb/infcmd.c > index c369b795757..abe9c933c9a 100644 > --- a/gdb/infcmd.c > +++ b/gdb/infcmd.c > @@ -735,7 +735,6 @@ continue_command (const char *args, int from_tty) > } > } > > - ERROR_NO_INFERIOR; > ensure_not_tfind_mode (); > > if (!non_stop || !all_threads_p) > -- > 2.25.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de> > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 > Looks correct. Maybe you could mention this happens inside the continue_command function in the commit message.
diff --git a/gdb/infcmd.c b/gdb/infcmd.c index c369b795757..abe9c933c9a 100644 --- a/gdb/infcmd.c +++ b/gdb/infcmd.c @@ -735,7 +735,6 @@ continue_command (const char *args, int from_tty) } } - ERROR_NO_INFERIOR; ensure_not_tfind_mode (); if (!non_stop || !all_threads_p)