diff mbox series

[v2,2/5,gdb/tdep] Fix amd64/i386_stack_frame_destroyed_p

Message ID 20230213142309.24366-3-tdevries@suse.de
State Committed
Headers
Series Assume epilogue unwind info is valid unless gcc < 4.5.0 |

Commit Message

Tom de Vries Feb. 13, 2023, 2:23 p.m. UTC 
  The use of compunit_epilogue_unwind_valid in both amd64_stack_frame_destroyed_p
and i386_stack_frame_destroyed_p is problematic, in the sense that the
functions no longer match their documented behaviour.

Fix this by moving the use of compunit_epilogue_unwind_valid to
amd64_epilogue_frame_sniffer and i386_epilogue_frame_sniffer.  NFC.
---
 gdb/amd64-tdep.c | 19 ++++++++++++-------
 gdb/i386-tdep.c  | 20 ++++++++++++--------
 2 files changed, 24 insertions(+), 15 deletions(-)
diff mbox series

Patch

diff --git a/gdb/amd64-tdep.c b/gdb/amd64-tdep.c
index d2e683b6fa8..0ec9b23922d 100644
--- a/gdb/amd64-tdep.c
+++ b/gdb/amd64-tdep.c
@@ -2903,9 +2903,6 @@  amd64_stack_frame_destroyed_p (struct gdbarch *gdbarch, CORE_ADDR pc)
 {
   gdb_byte insn;
 
-  if (compunit_epilogue_unwind_valid (find_pc_compunit_symtab (pc)))
-    return 0;
-
   if (target_read_memory (pc, &insn, 1))
     return 0;   /* Can't read memory at pc.  */
 
@@ -2920,11 +2917,19 @@  amd64_epilogue_frame_sniffer (const struct frame_unwind *self,
 			      frame_info_ptr this_frame,
 			      void **this_prologue_cache)
 {
-  if (frame_relative_level (this_frame) == 0)
-    return amd64_stack_frame_destroyed_p (get_frame_arch (this_frame),
-					  get_frame_pc (this_frame));
-  else
+  struct gdbarch *gdbarch = get_frame_arch (this_frame);
+  CORE_ADDR pc = get_frame_pc (this_frame);
+
+  if (frame_relative_level (this_frame) != 0)
+    /* We're not in the inner frame, so assume we're not in an epilogue.  */
     return 0;
+
+  if (compunit_epilogue_unwind_valid (find_pc_compunit_symtab (pc)))
+    /* Don't override the symtab unwinders.  */
+    return 0;
+
+  /* Check whether we're in an epilogue.  */
+  return amd64_stack_frame_destroyed_p (gdbarch, pc);
 }
 
 static struct amd64_frame_cache *
diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c
index 3fe548d8c68..5e797d098e8 100644
--- a/gdb/i386-tdep.c
+++ b/gdb/i386-tdep.c
@@ -2219,10 +2219,6 @@  static int
 i386_stack_frame_destroyed_p (struct gdbarch *gdbarch, CORE_ADDR pc)
 {
   gdb_byte insn;
-
-  if (compunit_epilogue_unwind_valid (find_pc_compunit_symtab (pc)))
-    return 0;
-
   if (target_read_memory (pc, &insn, 1))
     return 0;	/* Can't read memory at pc.  */
 
@@ -2237,11 +2233,19 @@  i386_epilogue_frame_sniffer (const struct frame_unwind *self,
 			     frame_info_ptr this_frame,
 			     void **this_prologue_cache)
 {
-  if (frame_relative_level (this_frame) == 0)
-    return i386_stack_frame_destroyed_p (get_frame_arch (this_frame),
-					 get_frame_pc (this_frame));
-  else
+  struct gdbarch *gdbarch = get_frame_arch (this_frame);
+  CORE_ADDR pc = get_frame_pc (this_frame);
+
+  if (frame_relative_level (this_frame) != 0)
+    /* We're not in the inner frame, so assume we're not in an epilogue.  */
+    return 0;
+
+  if (compunit_epilogue_unwind_valid (find_pc_compunit_symtab (pc)))
+    /* Don't override the symtab unwinders.  */
     return 0;
+
+  /* Check whether we're in an epilogue.  */
+  return i386_stack_frame_destroyed_p (gdbarch, pc);
 }
 
 static struct i386_frame_cache *