diff mbox series

Only allow downcasts in checked_static_cast

Message ID 20230211161751.3813270-1-tom@tromey.com
State New
Headers
Series Only allow downcasts in checked_static_cast |

Commit Message

Tom Tromey Feb. 11, 2023, 4:17 p.m. UTC 
  It didn't make sense to me that checked_static_cast allows upcasts, as
it seems to me that it is better to simply not write an explicit
upcast, but instead just allow the implicit derived-to-base
conversion.

This patch removes the downcast check from checked_static_cast.  It
also doesn't allow casts to the identical type, as this also did not
seem necessary.

Tested by rebuilding.
---
 gdbsupport/gdb-checked-static-cast.h | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/gdbsupport/gdb-checked-static-cast.h b/gdbsupport/gdb-checked-static-cast.h
index bc75244bddd..ede0f6da1bc 100644
--- a/gdbsupport/gdb-checked-static-cast.h
+++ b/gdbsupport/gdb-checked-static-cast.h
@@ -30,7 +30,10 @@  namespace gdb
    work for polymorphic types.
 
    In non-developer (i.e. production) builds, the dynamic_cast is replaced
-   with a static_cast which is usually significantly faster.  */
+   with a static_cast which is usually significantly faster.
+
+   This is intended only to be used for downcasts.  For upcasts, you
+   can safely omit the cast.  */
 
 template<typename T, typename V>
 T
@@ -48,10 +51,10 @@  checked_static_cast (V *v)
   /* In developer mode this cast uses dynamic_cast to confirm at run-time
      that the cast from V* to T is valid.  However, we can catch some
      mistakes at compile time, this assert prevents anything other than
-     downcasts, or casts to same type.  */
+     downcasts.  */
   static_assert (std::is_base_of<V, T_no_P>::value
-		 || std::is_base_of<T_no_P, V>::value,
-		 "types must be related");
+		 && !std::is_same<V, T_no_P>::value,
+		 "target type must be derived from actual type");
 
 #ifdef DEVELOPMENT
   if (v == nullptr)