diff mbox series

gdb/testsuite: don't delete command files in gdb.base/commands.exp

Message ID 20221214211403.635684-1-simon.marchi@polymtl.ca
State Committed
Commit 69de431392408c2fe25227908612e2bfe7b05036
Headers
Series gdb/testsuite: don't delete command files in gdb.base/commands.exp |

Commit Message

Simon Marchi Dec. 14, 2022, 9:14 p.m. UTC 
  Don't delete the runtime-generated command files.  This makes it easier
to reproduce tests by hand.

Change-Id: I4e53484eea216512f1c5d7dfcb5c464b36950946
---
 gdb/testsuite/gdb.base/commands.exp | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)


base-commit: 5d80df4a109e7b648e324423a5fbc3c1ba02e816

Comments

Tom Tromey Dec. 15, 2022, 7:20 p.m. UTC | #1 
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> Don't delete the runtime-generated command files.  This makes it easier
Simon> to reproduce tests by hand.

Seems like a good idea to me.

Tom
diff mbox series

Patch

diff --git a/gdb/testsuite/gdb.base/commands.exp b/gdb/testsuite/gdb.base/commands.exp
index 933978c0ea10..929a48e47dc3 100644
--- a/gdb/testsuite/gdb.base/commands.exp
+++ b/gdb/testsuite/gdb.base/commands.exp
@@ -714,8 +714,6 @@  maintenance deprecate set qqq_aaa"
     gdb_test "set qqq_aaa" \
 	"Warning: 'set qqq_aaa', an alias for the command 'set xxx_yyy', is deprecated\\.\r\n.*No alternative known\\..*" \
 	"deprecated alias with prefix give a warning"
-
-    file delete $file1
 }
 
 # Test that the help for a command does not show deprecated aliases.
@@ -848,7 +846,7 @@  proc_with_prefix stray_arg0_test { } {
 
 # Test that GDB is able to source a file with an indented comment.
 proc_with_prefix source_file_with_indented_comment {} {
-    set file1 [standard_output_file file1]
+    set file1 [standard_output_file source_file_with_indented_comment]
 
     set fd [open "$file1" w]
     puts $fd \
@@ -864,9 +862,9 @@  echo Done!\n}
 # Test that GDB can handle arguments when sourcing files recursively.
 # If the arguments are overwritten with ####### then the test has failed.
 proc_with_prefix recursive_source_test {} {
-    set file1 [standard_output_file file1]
-    set file2 [standard_output_file file2]
-    set file3 [standard_output_file file3]
+    set file1 [standard_output_file recursive_source_1]
+    set file2 [standard_output_file recursive_source_2]
+    set file3 [standard_output_file recursive_source_3]
 
     set fd [open "$file1" w]
     puts $fd \
@@ -892,10 +890,6 @@  end"
     gdb_test "source $file1" \
 	"1: <<<qwerty>>>\[\r\n]+in file3\[\r\n]+2: <<<qwerty>>>" \
 	"source file"
-
-    file delete $file1
-    file delete $file2
-    file delete $file3
 }
 
 proc gdb_test_no_prompt { command result msg } {