Silence libtool during link
Commit Message
The switch to linking with libtool now shows a very long link line
even when V=0. This patch arranges to silence libtool in this
situation.
---
gdb/Makefile.in | 2 +-
gdb/silent-rules.mk | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
Comments
On 11/7/22 13:13, Tom Tromey via Gdb-patches wrote:
> The switch to linking with libtool now shows a very long link line
> even when V=0. This patch arranges to silence libtool in this
> situation.
> ---
> gdb/Makefile.in | 2 +-
> gdb/silent-rules.mk | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 522fc20bccd..0f5df2ccb7b 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -148,7 +148,7 @@ LIBTOOL = @LIBTOOL@
> # Set this up with gcc if you have gnu ld and the loader will print out
> # line numbers for undefined references.
> #CC_LD = g++ -static
> -CC_LD = $(LIBTOOL) --mode=link $(CXX) $(CXX_DIALECT)
> +CC_LD = $(LIBTOOL) $(SILENT_FLAG) --mode=link $(CXX) $(CXX_DIALECT)
>
> # Where is our "include" directory? Typically $(srcdir)/../include.
> # This is essentially the header file directory for the library
> diff --git a/gdb/silent-rules.mk b/gdb/silent-rules.mk
> index c2c43481296..36791f6683f 100644
> --- a/gdb/silent-rules.mk
> +++ b/gdb/silent-rules.mk
> @@ -18,4 +18,6 @@ ECHO_LEX = @echo " LEX $@";
> ECHO_AR = @echo " AR $@";
> ECHO_RANLIB = @echo " RANLIB $@";
> SILENCE = @
> +# Silence libtool.
> +SILENT_FLAG = --silent
> endif
Oops, I had not noticed that during review. LGTM:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
@@ -148,7 +148,7 @@ LIBTOOL = @LIBTOOL@
# Set this up with gcc if you have gnu ld and the loader will print out
# line numbers for undefined references.
#CC_LD = g++ -static
-CC_LD = $(LIBTOOL) --mode=link $(CXX) $(CXX_DIALECT)
+CC_LD = $(LIBTOOL) $(SILENT_FLAG) --mode=link $(CXX) $(CXX_DIALECT)
# Where is our "include" directory? Typically $(srcdir)/../include.
# This is essentially the header file directory for the library
@@ -18,4 +18,6 @@ ECHO_LEX = @echo " LEX $@";
ECHO_AR = @echo " AR $@";
ECHO_RANLIB = @echo " RANLIB $@";
SILENCE = @
+# Silence libtool.
+SILENT_FLAG = --silent
endif