diff mbox series

Fix assert in handle_jit_event

Message ID 20221012145238.GA3706@delia.home
State Committed
Commit 508ccf9b3e1db355037a4a1c9004efe0d6d3ffbf
Headers
Series Fix assert in handle_jit_event |

Commit Message

Tom de Vries Oct. 12, 2022, 2:52 p.m. UTC 
  Hi,

With the cc-with-tweaks.sh patch submitted here (
https://sourceware.org/pipermail/gdb-patches/2022-October/192586.html ) we run
with:
...
$ export STRIP_ARGS_STRIP_DEBUG=--strip-all
$ make check RUNTESTFLAGS="gdb.base/jit-reader.exp \
    --target_board cc-with-gnu-debuglink"
...
into the following assert:
...
(gdb) run ^M
Starting program: jit-reader ^M
gdb/jit.c:1247: internal-error: jit_event_handler: \
  Assertion `jiter->jiter_data != nullptr' failed.^M
...

Fix this by handling the
jit_bp_sym.objfile->separate_debug_objfile_backlink != nullptr case in
handle_jit_event.

Tested on x86_64-linux.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29277

Any comments?

Thanks,
- Tom

[gdb] Fix assert in handle_jit_event

---
 gdb/breakpoint.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Tom de Vries Oct. 19, 2022, 3:42 p.m. UTC | #1 
On 10/12/22 16:52, Tom de Vries wrote:
> Hi,
> 
> With the cc-with-tweaks.sh patch submitted here (
> https://sourceware.org/pipermail/gdb-patches/2022-October/192586.html ) we run
> with:
> ...
> $ export STRIP_ARGS_STRIP_DEBUG=--strip-all
> $ make check RUNTESTFLAGS="gdb.base/jit-reader.exp \
>      --target_board cc-with-gnu-debuglink"
> ...
> into the following assert:
> ...
> (gdb) run ^M
> Starting program: jit-reader ^M
> gdb/jit.c:1247: internal-error: jit_event_handler: \
>    Assertion `jiter->jiter_data != nullptr' failed.^M
> ...
> 
> Fix this by handling the
> jit_bp_sym.objfile->separate_debug_objfile_backlink != nullptr case in
> handle_jit_event.
> 
> Tested on x86_64-linux.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29277
> 
> Any comments?
> 

Committed.

Thanks,
- Tom

> [gdb] Fix assert in handle_jit_event
> 
> ---
>   gdb/breakpoint.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index e9aee6315fa..902a9baa3e0 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -5685,7 +5685,10 @@ handle_jit_event (CORE_ADDR address)
>        function needs to be updated too.  */
>     bound_minimal_symbol jit_bp_sym = lookup_minimal_symbol_by_pc (address);
>     gdb_assert (jit_bp_sym.objfile != nullptr);
> -  jit_event_handler (gdbarch, jit_bp_sym.objfile);
> +  objfile *objfile = jit_bp_sym.objfile;
> +  if (objfile->separate_debug_objfile_backlink)
> +    objfile = objfile->separate_debug_objfile_backlink;
> +  jit_event_handler (gdbarch, objfile);
>   
>     target_terminal::inferior ();
>   }
diff mbox series

Patch

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index e9aee6315fa..902a9baa3e0 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -5685,7 +5685,10 @@  handle_jit_event (CORE_ADDR address)
      function needs to be updated too.  */
   bound_minimal_symbol jit_bp_sym = lookup_minimal_symbol_by_pc (address);
   gdb_assert (jit_bp_sym.objfile != nullptr);
-  jit_event_handler (gdbarch, jit_bp_sym.objfile);
+  objfile *objfile = jit_bp_sym.objfile;
+  if (objfile->separate_debug_objfile_backlink)
+    objfile = objfile->separate_debug_objfile_backlink;
+  jit_event_handler (gdbarch, objfile);
 
   target_terminal::inferior ();
 }