diff mbox

[gdb/testsuite] Remove stale exec in gdb_compile_ada

Message ID 20200213104740.GA9654@delia
State New
Headers show

Commit Message

Tom de Vries Feb. 13, 2020, 10:47 a.m. UTC
Hi,

When running test-case gdb.ada/ptype_tagged_param.exp, I get:
...
PASS: gdb.ada/ptype_tagged_param.exp: compilation foo.adb
...

However, when I then de-install gnatmake and run again, I get the same result.
This is due to a stale exec. After removing the stale exec, I get:
...
UNSUPPORTED: gdb.ada/ptype_tagged_param.exp: compilation foo.adb
...

Fix this removing the stale exec in gdb_compile_ada before compilation.

Tested on x86_64-linux.

OK for trunk?

Thanks,
- Tom

[gdb/testsuite] Remove stale exec in gdb_compile_ada

gdb/testsuite/ChangeLog:

2020-02-13  Tom de Vries  <tdevries@suse.de>

	* lib/ada.exp (gdb_compile_ada): Delete stale exec before compilation.

---
 gdb/testsuite/lib/ada.exp | 2 ++
 1 file changed, 2 insertions(+)

Comments

Tom Tromey Feb. 13, 2020, 2:23 p.m. UTC | #1
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> 2020-02-13  Tom de Vries  <tdevries@suse.de>

Tom> 	* lib/ada.exp (gdb_compile_ada): Delete stale exec before compilation.

This is ok.  Thank you.

I would assume there are other weird bugs like this in the test suite.
One way to ensure a clean run is to remove the outputs and cache
directories.

Tom
diff mbox

Patch

diff --git a/gdb/testsuite/lib/ada.exp b/gdb/testsuite/lib/ada.exp
index 726977d98f..9933cc951e 100644
--- a/gdb/testsuite/lib/ada.exp
+++ b/gdb/testsuite/lib/ada.exp
@@ -60,6 +60,8 @@  proc gdb_compile_ada {source dest type options} {
     set gprdir [file dirname $srcdir]
     set objdir [file dirname $dest]
 
+    file delete $dest
+
     # Although strictly not necessary, we force the recompilation
     # of all units (additional_flags=-f).  This is what is done
     # when using GCC to build programs in the other languages,