Message ID | 20190801172647.64620-1-cbiesinger@google.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 21989 invoked by alias); 1 Aug 2019 17:26:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 21981 invoked by uid 89); 1 Aug 2019 17:26:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.1 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-qk1-f201.google.com Received: from mail-qk1-f201.google.com (HELO mail-qk1-f201.google.com) (209.85.222.201) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Aug 2019 17:26:53 +0000 Received: by mail-qk1-f201.google.com with SMTP id x17so61949445qkf.14 for <gdb-patches@sourceware.org>; Thu, 01 Aug 2019 10:26:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=M2bmq8yuj1/jVekXPdOs1BuHtSd+dQcoYLIL+do39KQ=; b=OsSULIoOWhRQk0ft6elLyL6f+YWdhmwyxe02Axj2t1FhdHPftYv9+62UCV/OIYqeb5 Yg0C6A4ZrgstcKsyp8L06y9xoB/Bah25MxUGoHEgu1lJzjQrNZ6m0FkGl+pSSv7thGsl 0Imn+LIXlyyl5OzlQkyogezAsPQ/2w7YUXU3Y/9KUcjB0dNhxWr/5+GhK4eDdlDG4bHs QUjKauhmAq55F0Vp64joCbq4l/9k+M/fFX8XsYcZu0rNusrDXOj4ZNvXq1KhWQHFS4Pv cAVYyHRA68u1r4LtXLm0HD3SLy1aWokvCUtkb53MQH8qfvA5wzTmmm3PPELOvx87F95e WHFA== Date: Thu, 1 Aug 2019 12:26:47 -0500 In-Reply-To: <20190801170141.198456-1-cbiesinger@google.com> Message-Id: <20190801172647.64620-1-cbiesinger@google.com> Mime-Version: 1.0 References: <20190801170141.198456-1-cbiesinger@google.com> Subject: [PATCH] Include s12z-opc.h using ../opcodes. From: "Christian Biesinger via gdb-patches" <gdb-patches@sourceware.org> Reply-To: Christian Biesinger <cbiesinger@google.com> To: gdb-patches@sourceware.org Cc: Christian Biesinger <cbiesinger@google.com> Content-Type: text/plain; charset="UTF-8" |
Commit Message
Terekhov, Mikhail via Gdb-patches
Aug. 1, 2019, 5:26 p.m. UTC
This file exists in binutils-gdb/opcodes, and nothing in Makefile.in adds this to the include path. Default builds work because in-tree readline adds binutils-gdb/ to the include path (!). However, this is broken when compiling with system readline. Other files already use this way to include files in opcodes: ./gdb/lm32-tdep.c:#include "../opcodes/lm32-desc.h" ./gdb/or1k-tdep.h:#include "../opcodes/or1k-desc.h" ./gdb/mep-tdep.c:#include "../opcodes/mep-desc.h" etc. gdb/ChangeLog: 2019-08-01 Christian Biesinger <cbiesinger@google.com> * s12z-tdep.c: Fix include path for s12z-opc.h. --- gdb/s12z-tdep.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 2019-08-01 1:26 p.m., Christian Biesinger via gdb-patches wrote: > This file exists in binutils-gdb/opcodes, and nothing in Makefile.in adds this > to the include path. Default builds work because in-tree readline adds > binutils-gdb/ to the include path (!). However, this is broken when compiling > with system readline. Yeah, my guess is that the include path is added when using the in-tree readline to make #include "readline/readline.h" work. And it made this include work by chance. > Other files already use this way to include files in opcodes: > ./gdb/lm32-tdep.c:#include "../opcodes/lm32-desc.h" > ./gdb/or1k-tdep.h:#include "../opcodes/or1k-desc.h" > ./gdb/mep-tdep.c:#include "../opcodes/mep-desc.h" > > etc. > > gdb/ChangeLog: > > 2019-08-01 Christian Biesinger <cbiesinger@google.com> > > * s12z-tdep.c: Fix include path for s12z-opc.h. > --- > gdb/s12z-tdep.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/s12z-tdep.c b/gdb/s12z-tdep.c > index a9d20e809c..a1c085cfbb 100644 > --- a/gdb/s12z-tdep.c > +++ b/gdb/s12z-tdep.c > @@ -30,7 +30,7 @@ > #include "opcode/s12z.h" > #include "trad-frame.h" > #include "remote.h" > -#include "opcodes/s12z-opc.h" > +#include "../opcodes/s12z-opc.h" > > /* Two of the registers included in S12Z_N_REGISTERS are > the CCH and CCL "registers" which are just views into > Thanks, the patch LGTM. Simon
On Thu, Aug 1, 2019 at 12:30 PM Simon Marchi <simark@simark.ca> wrote: > > On 2019-08-01 1:26 p.m., Christian Biesinger via gdb-patches wrote: > > This file exists in binutils-gdb/opcodes, and nothing in Makefile.in adds this > > to the include path. Default builds work because in-tree readline adds > > binutils-gdb/ to the include path (!). However, this is broken when compiling > > with system readline. > > Yeah, my guess is that the include path is added when using the in-tree readline to make > #include "readline/readline.h" work. And it made this include work by chance. > > > Other files already use this way to include files in opcodes: > > ./gdb/lm32-tdep.c:#include "../opcodes/lm32-desc.h" > > ./gdb/or1k-tdep.h:#include "../opcodes/or1k-desc.h" > > ./gdb/mep-tdep.c:#include "../opcodes/mep-desc.h" > > > > etc. > > > > gdb/ChangeLog: > > > > 2019-08-01 Christian Biesinger <cbiesinger@google.com> > > > > * s12z-tdep.c: Fix include path for s12z-opc.h. > > --- > > gdb/s12z-tdep.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/gdb/s12z-tdep.c b/gdb/s12z-tdep.c > > index a9d20e809c..a1c085cfbb 100644 > > --- a/gdb/s12z-tdep.c > > +++ b/gdb/s12z-tdep.c > > @@ -30,7 +30,7 @@ > > #include "opcode/s12z.h" > > #include "trad-frame.h" > > #include "remote.h" > > -#include "opcodes/s12z-opc.h" > > +#include "../opcodes/s12z-opc.h" > > > > /* Two of the registers included in S12Z_N_REGISTERS are > > the CCH and CCL "registers" which are just views into > > > Thanks, the patch LGTM. Thanks, pushed.
diff --git a/gdb/s12z-tdep.c b/gdb/s12z-tdep.c index a9d20e809c..a1c085cfbb 100644 --- a/gdb/s12z-tdep.c +++ b/gdb/s12z-tdep.c @@ -30,7 +30,7 @@ #include "opcode/s12z.h" #include "trad-frame.h" #include "remote.h" -#include "opcodes/s12z-opc.h" +#include "../opcodes/s12z-opc.h" /* Two of the registers included in S12Z_N_REGISTERS are the CCH and CCL "registers" which are just views into