[1/4] gdb: Add builtin types for 24 bit integers.
Commit Message
Add int24 and uint24. These are used by the upcoming S12Z target, but will be
needed for any arch which features 24 bit registers.
* gdb/gdbtypes.h (struct builtin_type): New members builtin_int24
and builtin_uint24;
* gdb/gdbtypes.c: Initialize them.
* gdb/doc/gdb.texinfo (Predefined Target Types): Mention types int24 and uint24.
---
gdb/doc/gdb.texinfo | 2 ++
gdb/gdbtypes.c | 4 ++++
gdb/gdbtypes.h | 2 ++
3 files changed, 8 insertions(+)
Comments
>>>>> "John" == John Darrington <john@darrington.wattle.id.au> writes:
John> Add int24 and uint24. These are used by the upcoming S12Z target, but will be
John> needed for any arch which features 24 bit registers.
John> * gdb/gdbtypes.h (struct builtin_type): New members builtin_int24
John> and builtin_uint24;
John> * gdb/gdbtypes.c: Initialize them.
John> * gdb/doc/gdb.texinfo (Predefined Target Types): Mention types int24 and uint24.
The non-documentation parts are ok.
Tom
On Fri, Sep 07, 2018 at 04:03:38PM -0600, Tom Tromey wrote:
>>>>> "John" == John Darrington <john@darrington.wattle.id.au> writes:
John> Add int24 and uint24. These are used by the upcoming S12Z target, but will be
John> needed for any arch which features 24 bit registers.
John> * gdb/gdbtypes.h (struct builtin_type): New members builtin_int24
John> and builtin_uint24;
John> * gdb/gdbtypes.c: Initialize them.
John> * gdb/doc/gdb.texinfo (Predefined Target Types): Mention types int24 and uint24.
The non-documentation parts are ok.
... and what's wrong with the documentation part ?
J'
>>>>> "John" == John Darrington <john@darrington.wattle.id.au> writes:
Tom> The non-documentation parts are ok.
John> ... and what's wrong with the documentation part ?
Eli reviews those.
Tom
@@ -42379,6 +42379,7 @@ Boolean type, occupying a single bit.
@item int8
@itemx int16
+@itemx int24
@itemx int32
@itemx int64
@itemx int128
@@ -42386,6 +42387,7 @@ Signed integer types holding the specified number of bits.
@item uint8
@itemx uint16
+@itemx uint24
@itemx uint32
@itemx uint64
@itemx uint128
@@ -5402,6 +5402,10 @@ gdbtypes_post_init (struct gdbarch *gdbarch)
= arch_integer_type (gdbarch, 16, 0, "int16_t");
builtin_type->builtin_uint16
= arch_integer_type (gdbarch, 16, 1, "uint16_t");
+ builtin_type->builtin_int24
+ = arch_integer_type (gdbarch, 24, 0, "int24_t");
+ builtin_type->builtin_uint24
+ = arch_integer_type (gdbarch, 24, 1, "uint24_t");
builtin_type->builtin_int32
= arch_integer_type (gdbarch, 32, 0, "int32_t");
builtin_type->builtin_uint32
@@ -1611,6 +1611,8 @@ struct builtin_type
struct type *builtin_uint8;
struct type *builtin_int16;
struct type *builtin_uint16;
+ struct type *builtin_int24;
+ struct type *builtin_uint24;
struct type *builtin_int32;
struct type *builtin_uint32;
struct type *builtin_int64;