diff mbox

Remove old lint code

Message ID 20180729212952.28056-1-tom@tromey.com
State New
Headers show

Commit Message

Tom Tromey July 29, 2018, 9:29 p.m. UTC
This removes dead code that, according to the comments, existed to
placate lint.  I don't think this has been relevant in a long time,
and certainly not since gdb switched to C++.

Tested by rebuilding.

ChangeLog
2018-07-29  Tom Tromey  <tom@tromey.com>

	* cli/cli-decode.c (lookup_cmd): Remove lint code.
	* value.c (unpack_long): Remove lint code.
	* valops.c (value_ind): Remove lint code.
	* valarith.c (value_x_binop, value_x_unop, value_equal)
	(value_pos): Remove lint code.
---
 gdb/ChangeLog        |  8 ++++++++
 gdb/cli/cli-decode.c |  1 -
 gdb/valarith.c       | 20 +++-----------------
 gdb/valops.c         |  1 -
 gdb/value.c          |  1 -
 5 files changed, 11 insertions(+), 20 deletions(-)

Comments

Simon Marchi July 30, 2018, 1:56 p.m. UTC | #1
On 2018-07-29 17:29, Tom Tromey wrote:
> This removes dead code that, according to the comments, existed to
> placate lint.  I don't think this has been relevant in a long time,
> and certainly not since gdb switched to C++.

LGTM.  Do you have any idea what lint tool that was?

Simon
Tom Tromey July 30, 2018, 2:28 p.m. UTC | #2
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> On 2018-07-29 17:29, Tom Tromey wrote:
>> This removes dead code that, according to the comments, existed to
>> placate lint.  I don't think this has been relevant in a long time,
>> and certainly not since gdb switched to C++.

Simon> LGTM.  Do you have any idea what lint tool that was?

No, but I assume just the old Unix "lint" program.

Tom
diff mbox

Patch

diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c
index c8dda700ca8..83dd67efe3f 100644
--- a/gdb/cli/cli-decode.c
+++ b/gdb/cli/cli-decode.c
@@ -1561,7 +1561,6 @@  lookup_cmd (const char **line, struct cmd_list_element *list,
 	      }
 	  error (_("Ambiguous %scommand \"%s\": %s."), local_cmdtype,
 		 *line, ambbuf);
-	  return 0;		/* lint */
 	}
     }
   else
diff --git a/gdb/valarith.c b/gdb/valarith.c
index d2dd5900647..01ca50d3d21 100644
--- a/gdb/valarith.c
+++ b/gdb/valarith.c
@@ -504,9 +504,6 @@  value_x_binop (struct value *arg1, struct value *arg2, enum exp_opcode op,
     }
   throw_error (NOT_FOUND_ERROR,
                _("member function %s not found"), tstr);
-#ifdef lint
-  return call_function_by_hand (argvec[0], 2 - static_memfuncp, argvec + 1);
-#endif
 }
 
 /* We know that arg1 is a structure, so try to find a unary user
@@ -622,8 +619,6 @@  value_x_unop (struct value *arg1, enum exp_opcode op, enum noside noside)
     }
   throw_error (NOT_FOUND_ERROR,
                _("member function %s not found"), tstr);
-
-  return 0;			/* For lint -- never reached */
 }
 
 
@@ -1533,10 +1528,7 @@  value_equal (struct value *arg1, struct value *arg2)
       return value_strcmp (arg1, arg2) == 0;
     }
   else
-    {
-      error (_("Invalid type combination in equality test."));
-      return 0;			/* For lint -- never reached.  */
-    }
+    error (_("Invalid type combination in equality test."));
 }
 
 /* Compare values based on their raw contents.  Useful for arrays since
@@ -1628,10 +1620,7 @@  value_pos (struct value *arg1)
       || (TYPE_CODE (type) == TYPE_CODE_ARRAY && TYPE_VECTOR (type)))
     return value_from_contents (type, value_contents (arg1));
   else
-    {
-      error (_("Argument to positive operation not a number."));
-      return 0;			/* For lint -- never reached.  */
-    }
+    error (_("Argument to positive operation not a number."));
 }
 
 struct value *
@@ -1663,10 +1652,7 @@  value_neg (struct value *arg1)
       return val;
     }
   else
-    {
-      error (_("Argument to negate operation not a number."));
-      return 0;			/* For lint -- never reached.  */
-    }
+    error (_("Argument to negate operation not a number."));
 }
 
 struct value *
diff --git a/gdb/valops.c b/gdb/valops.c
index 9bdbf22b03c..de6f839c33c 100644
--- a/gdb/valops.c
+++ b/gdb/valops.c
@@ -1588,7 +1588,6 @@  value_ind (struct value *arg1)
     }
 
   error (_("Attempt to take contents of a non-pointer value."));
-  return 0;			/* For lint -- never reached.  */
 }
 
 /* Create a value for an array by allocating space in GDB, copying the
diff --git a/gdb/value.c b/gdb/value.c
index af635ba5bc3..b0f22f1117e 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -2777,7 +2777,6 @@  unpack_long (struct type *type, const gdb_byte *valaddr)
     default:
       error (_("Value can't be converted to integer."));
     }
-  return 0;			/* Placate lint.  */
 }
 
 /* Unpack raw data (copied from debugee, target byte order) at VALADDR