diff mbox

[RFC,symtab] Warn about unresolved DW_AT_upper_bound/DW_AT_count

Message ID 20180718171814.br2yfrfajkyk6i2j@delia
State New, archived
Headers

Commit Message

Tom de Vries July 18, 2018, 5:18 p.m. UTC 
  Hi,

this patch (without test-case for now) generates a warning if
DW_AT_upper_bound or DW_AT_count is defined, but can't be translated.  This
is triggered for current gcc in lto mode for vla test-cases.

F.i.:
...
$ gcc gcc/testsuite/gcc.dg/guality/vla-1.c -g -O2 -flto \
    -DPREVENT_OPTIMIZATION -o ./vla-1.exe
$ ./gdb -batch -ex "set complaints 10" -ex "file ./vla-1.exe"
During symbol reading, Unresolved DW_AT_upper_bound - DIE at 0x337
  [in module vla-1.exe].
...

Good idea?

Any other comments?

Thanks,
- Tom

[gdb/symtab] Warn about unresolved DW_AT_upper_bound/DW_AT_count

2018-07-18  Tom de Vries  <tdevries@suse.de>

	* dwarf2read.c (read_subrange_type): Warn if DW_AT_upper_bound or
	DW_AT_count can't be translated to a dynamic prop.

---
 gdb/dwarf2read.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

Comments

Tom Tromey July 19, 2018, 2:40 p.m. UTC | #1 
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> this patch (without test-case for now) generates a warning if
Tom> DW_AT_upper_bound or DW_AT_count is defined, but can't be translated.  This
Tom> is triggered for current gcc in lto mode for vla test-cases.

Tom> F.i.:
Tom> ...
Tom> $ gcc gcc/testsuite/gcc.dg/guality/vla-1.c -g -O2 -flto \
Tom>     -DPREVENT_OPTIMIZATION -o ./vla-1.exe
Tom> $ ./gdb -batch -ex "set complaints 10" -ex "file ./vla-1.exe"
Tom> During symbol reading, Unresolved DW_AT_upper_bound - DIE at 0x337
Tom>   [in module vla-1.exe].
Tom> ...

Tom> Good idea?

I think so.

Tom> +	  if (attr_ub)
[...]
Tom> +	  if (attr_count)

The gdb style is to use a check against nullptr in these spots.

Tom
diff mbox

Patch

diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index b7933de49c..3f696ea060 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -17596,10 +17596,11 @@  read_subrange_type (struct die_info *die, struct dwarf2_cu *cu)
 	       sect_offset_str (die->sect_off),
 	       objfile_name (cu->per_cu->dwarf2_per_objfile->objfile));
 
-  attr = dwarf2_attr (die, DW_AT_upper_bound, cu);
+  struct attribute *attr_ub, *attr_count;
+  attr = attr_ub = dwarf2_attr (die, DW_AT_upper_bound, cu);
   if (!attr_to_dynamic_prop (attr, die, cu, &high))
     {
-      attr = dwarf2_attr (die, DW_AT_count, cu);
+      attr = attr_count = dwarf2_attr (die, DW_AT_count, cu);
       if (attr_to_dynamic_prop (attr, die, cu, &high))
 	{
 	  /* If bounds are constant do the final calculation here.  */
@@ -17608,6 +17609,20 @@  read_subrange_type (struct die_info *die, struct dwarf2_cu *cu)
 	  else
 	    high_bound_is_count = 1;
 	}
+      else
+	{
+	  if (attr_ub)
+	    complaint (_("Unresolved DW_AT_upper_bound "
+			 "- DIE at %s [in module %s]"),
+		       sect_offset_str (die->sect_off),
+		       objfile_name (cu->per_cu->dwarf2_per_objfile->objfile));
+	  if (attr_count)
+	    complaint (_("Unresolved DW_AT_count "
+			 "- DIE at %s [in module %s]"),
+		       sect_offset_str (die->sect_off),
+		       objfile_name (cu->per_cu->dwarf2_per_objfile->objfile));
+	}
+	
     }
 
   /* Dwarf-2 specifications explicitly allows to create subrange types