[RFA,09/13] Pass the correct argument to the observer in reread_symbols
Commit Message
This is actually a patch I found via another route. Joel had asked me
to write a test, but I still have not found the time to do this.
Meanwhile, -Wunused-variable also found this error.
2018-07-12 Tom Tromey <tom@tromey.com>
* symfile.c (reread_symbols): Notify iter, not objfile.
---
gdb/ChangeLog | 4 ++++
gdb/symfile.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
Comments
On 2018-07-12 04:52 PM, Tom Tromey wrote:
> This is actually a patch I found via another route. Joel had asked me
> to write a test, but I still have not found the time to do this.
> Meanwhile, -Wunused-variable also found this error.
Heh, this is also a case of variables that should be declared in the
narrowest scope possible.
Simon
On 2018-07-12 10:49 PM, Simon Marchi wrote:
> On 2018-07-12 04:52 PM, Tom Tromey wrote:
>> This is actually a patch I found via another route. Joel had asked me
>> to write a test, but I still have not found the time to do this.
>> Meanwhile, -Wunused-variable also found this error.
>
> Heh, this is also a case of variables that should be declared in the
> narrowest scope possible.
>
> Simon
It wasn't clear, but this LGTM.
Simon
@@ -2608,7 +2608,7 @@ reread_symbols (void)
gdb::observers::new_objfile.notify (NULL) has been called by
clear_symtab_users above. Notify the new files now. */
for (auto iter : new_objfiles)
- gdb::observers::new_objfile.notify (objfile);
+ gdb::observers::new_objfile.notify (iter);
/* At least one objfile has changed, so we can consider that
the executable we're debugging has changed too. */