Message ID | 20180625080547.7629-1-thomas.petazzoni@bootlin.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 48718 invoked by alias); 25 Jun 2018 08:05:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 47642 invoked by uid 89); 25 Jun 2018 08:05:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=sk:thomas., Share, const*, gdbserver X-HELO: mail.bootlin.com Received: from mail.bootlin.com (HELO mail.bootlin.com) (62.4.15.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Jun 2018 08:05:55 +0000 Received: by mail.bootlin.com (Postfix, from userid 110) id 50F2A207D4; Mon, 25 Jun 2018 10:05:52 +0200 (CEST) Received: from localhost (AAubervilliers-681-1-50-153.w90-88.abo.wanadoo.fr [90.88.168.153]) by mail.bootlin.com (Postfix) with ESMTPSA id 20E91203D9; Mon, 25 Jun 2018 10:05:52 +0200 (CEST) From: Thomas Petazzoni <thomas.petazzoni@bootlin.com> To: gdb-patches@sourceware.org Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com> Subject: [PATCH] nat/fork-inferior: include linux-ptrace.h Date: Mon, 25 Jun 2018 10:05:47 +0200 Message-Id: <20180625080547.7629-1-thomas.petazzoni@bootlin.com> |
Commit Message
Thomas Petazzoni
June 25, 2018, 8:05 a.m. UTC
To decide whether fork() or vfork() should be used, fork-inferior.c
uses the following test:
#if !(defined(__UCLIBC__) && defined(HAS_NOMMU))
However, HAS_NOMMU is never defined, because it gets defined in
linux-ptrace.h, which is not included by fork-inferior.c. Due to this,
gdbserver fails to build on noMMU architectures. This commit fixes
that by simply including linux-ptrace.h.
This bug was introduced by commit
2090129c36c7e582943b7d300968d19b46160d84 ("Share fork_inferior et al
with gdbserver"). Indeed, the same fork()/vfork() selection was done,
but in another file where linux-ptrace.h was included.
Fixes the following build issue:
../nat/fork-inferior.c: In function 'pid_t fork_inferior(const char*, const string&, char**, void (*)(), void (*)(int), void (*)(), const char*, void (*)(const char*, char* const*, char* const*))':
../nat/fork-inferior.c:376:11: error: 'fork' was not declared in this scope
pid = fork ();
^~~~
../nat/fork-inferior.c:376:11: note: suggested alternative: 'vfork'
pid = fork ();
^~~~
vfork
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
gdb/nat/fork-inferior.c | 1 +
1 file changed, 1 insertion(+)
Comments
On 2018-06-25 04:05, Thomas Petazzoni wrote: > To decide whether fork() or vfork() should be used, fork-inferior.c > uses the following test: > > #if !(defined(__UCLIBC__) && defined(HAS_NOMMU)) > > However, HAS_NOMMU is never defined, because it gets defined in > linux-ptrace.h, which is not included by fork-inferior.c. Due to this, > gdbserver fails to build on noMMU architectures. This commit fixes > that by simply including linux-ptrace.h. > > This bug was introduced by commit > 2090129c36c7e582943b7d300968d19b46160d84 ("Share fork_inferior et al > with gdbserver"). Indeed, the same fork()/vfork() selection was done, > but in another file where linux-ptrace.h was included. > > Fixes the following build issue: > > ../nat/fork-inferior.c: In function 'pid_t fork_inferior(const char*, > const string&, char**, void (*)(), void (*)(int), void (*)(), const > char*, void (*)(const char*, char* const*, char* const*))': > ../nat/fork-inferior.c:376:11: error: 'fork' was not declared in this > scope > pid = fork (); > ^~~~ > ../nat/fork-inferior.c:376:11: note: suggested alternative: 'vfork' > pid = fork (); > ^~~~ > vfork > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> > --- > gdb/nat/fork-inferior.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/gdb/nat/fork-inferior.c b/gdb/nat/fork-inferior.c > index 8b59387fa5..05167628a6 100644 > --- a/gdb/nat/fork-inferior.c > +++ b/gdb/nat/fork-inferior.c > @@ -26,6 +26,7 @@ > #include "common-gdbthread.h" > #include "signals-state-save-restore.h" > #include "gdb_tilde_expand.h" > +#include "linux-ptrace.h" > #include <vector> > > extern char **environ; Hi Thomas, fork-inferior.c is also included in native builds for BSDs, AIX, Solaris and Darwin (see gdb/configure.nat). I am a bit concerned that linux-ptrace.h could use some Linux-specific things, and thus would break the other builds. However, I built-tested on FreeBSD and it seems fine. Worst case, we can probably wrap this include in "#ifdef __linux__" if that becomes a problem. Do you have push access, or do you prefer if I push the patch for you? I suppose that error was caught by a Buildroot autobuilder? Would it be possible to have the config, so I can add a similar configuration to my collection of cross-compiled GDB builds I use for build-testing? Thanks, Simon
On 06/27/2018 03:24 PM, Simon Marchi wrote: > On 2018-06-25 04:05, Thomas Petazzoni wrote: >> To decide whether fork() or vfork() should be used, fork-inferior.c >> uses the following test: >> >> #if !(defined(__UCLIBC__) && defined(HAS_NOMMU)) >> >> However, HAS_NOMMU is never defined, because it gets defined in >> linux-ptrace.h, which is not included by fork-inferior.c. Due to this, >> gdbserver fails to build on noMMU architectures. This commit fixes >> that by simply including linux-ptrace.h. >> >> This bug was introduced by commit >> 2090129c36c7e582943b7d300968d19b46160d84 ("Share fork_inferior et al >> with gdbserver"). Indeed, the same fork()/vfork() selection was done, >> but in another file where linux-ptrace.h was included. >> >> Fixes the following build issue: >> >> ../nat/fork-inferior.c: In function 'pid_t fork_inferior(const char*, >> const string&, char**, void (*)(), void (*)(int), void (*)(), const >> char*, void (*)(const char*, char* const*, char* const*))': >> ../nat/fork-inferior.c:376:11: error: 'fork' was not declared in this scope >> pid = fork (); >> ^~~~ >> ../nat/fork-inferior.c:376:11: note: suggested alternative: 'vfork' >> pid = fork (); >> ^~~~ >> vfork >> >> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> >> --- >> gdb/nat/fork-inferior.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/gdb/nat/fork-inferior.c b/gdb/nat/fork-inferior.c >> index 8b59387fa5..05167628a6 100644 >> --- a/gdb/nat/fork-inferior.c >> +++ b/gdb/nat/fork-inferior.c >> @@ -26,6 +26,7 @@ >> #include "common-gdbthread.h" >> #include "signals-state-save-restore.h" >> #include "gdb_tilde_expand.h" >> +#include "linux-ptrace.h" >> #include <vector> >> >> extern char **environ; > > Hi Thomas, > > fork-inferior.c is also included in native builds for BSDs, AIX, Solaris and Darwin (see gdb/configure.nat). I am a bit concerned that linux-ptrace.h could use some Linux-specific things, and thus would break the other builds. However, I built-tested on FreeBSD and it seems fine. Worst case, we can probably wrap this include in "#ifdef __linux__" if that becomes a problem. Please don't. It seems very wrong to me to include this header on other hosts. It is full of Linux-only details. Thanks, Pedro Alves
Hello Simon, On Wed, 27 Jun 2018 10:24:07 -0400, Simon Marchi wrote: > > diff --git a/gdb/nat/fork-inferior.c b/gdb/nat/fork-inferior.c > > index 8b59387fa5..05167628a6 100644 > > --- a/gdb/nat/fork-inferior.c > > +++ b/gdb/nat/fork-inferior.c > > @@ -26,6 +26,7 @@ > > #include "common-gdbthread.h" > > #include "signals-state-save-restore.h" > > #include "gdb_tilde_expand.h" > > +#include "linux-ptrace.h" > > #include <vector> > > > > extern char **environ; > > Hi Thomas, > > fork-inferior.c is also included in native builds for BSDs, AIX, Solaris > and Darwin (see gdb/configure.nat). I am a bit concerned that > linux-ptrace.h could use some Linux-specific things, and thus would > break the other builds. However, I built-tested on FreeBSD and it seems > fine. Worst case, we can probably wrap this include in "#ifdef > __linux__" if that becomes a problem. Or better, this horrible mess of __UCLIBC__ and HAS_NOMMU macros should be replaced by a proper autoconf check testing for the availability of fork(). > Do you have push access, or do you prefer if I push the patch for you? I don't have push access. > I suppose that error was caught by a Buildroot autobuilder? Would it be > possible to have the config, so I can add a similar configuration to my > collection of cross-compiled GDB builds I use for build-testing? The error wasn't caught by the autobuilders, but by the automated build logic we use for http://toolchains.bootlin.com to build toolchains for a wide range of CPU architectures. The failure was https://gitlab.com/free-electrons/toolchains-builder/-/jobs/77021057, and the Buildroot configuration being built was: BR2_m68k=y BR2_m68k_cf5208=y BR2_WGET="wget --passive-ftp -nd -t 3 --no-check-certificate" BR2_HOST_DIR="/opt/m68k-coldfire--uclibc--bleeding-edge-2018.06-1" BR2_GNU_MIRROR="http://ftp.gnu.org/pub/gnu" BR2_KERNEL_HEADERS_4_14=y BR2_TOOLCHAIN_BUILDROOT_LOCALE=y BR2_PTHREAD_DEBUG=y BR2_BINUTILS_VERSION_2_30_X=y BR2_GCC_VERSION_8_X=y BR2_TOOLCHAIN_BUILDROOT_CXX=y BR2_PACKAGE_HOST_GDB=y BR2_GDB_VERSION_8_1=y BR2_INIT_NONE=y # BR2_PACKAGE_BUSYBOX is not set BR2_PACKAGE_GDB=y # BR2_TARGET_ROOTFS_TAR is not set Note that with Buildroot's latest master, this configuration will build fine, because we already merged the fix for the fork/vfork issue. Best regards, Thomas Petazzoni
On 2018-06-27 10:31, Thomas Petazzoni wrote: >> fork-inferior.c is also included in native builds for BSDs, AIX, >> Solaris >> and Darwin (see gdb/configure.nat). I am a bit concerned that >> linux-ptrace.h could use some Linux-specific things, and thus would >> break the other builds. However, I built-tested on FreeBSD and it >> seems >> fine. Worst case, we can probably wrap this include in "#ifdef >> __linux__" if that becomes a problem. > > Or better, this horrible mess of __UCLIBC__ and HAS_NOMMU macros should > be replaced by a proper autoconf check testing for the availability of > fork(). Agreed, and I think Pedro will agree too (unless you can think of a simpler solution that doesn't involve autoconf?). Simon
> > > fork-inferior.c is also included in native builds for BSDs, AIX, > > > Solaris > > > and Darwin (see gdb/configure.nat). I am a bit concerned that > > > linux-ptrace.h could use some Linux-specific things, and thus would > > > break the other builds. However, I built-tested on FreeBSD and it > > > seems > > > fine. Worst case, we can probably wrap this include in "#ifdef > > > __linux__" if that becomes a problem. > > > > Or better, this horrible mess of __UCLIBC__ and HAS_NOMMU macros should > > be replaced by a proper autoconf check testing for the availability of > > fork(). > > Agreed, and I think Pedro will agree too (unless you can think of a simpler > solution that doesn't involve autoconf?). We already autoconf for "fork" (see HAVE_FORK in config.in). Does that help?
On 06/27/2018 03:34 PM, Simon Marchi wrote: > On 2018-06-27 10:31, Thomas Petazzoni wrote: >>> fork-inferior.c is also included in native builds for BSDs, AIX, Solaris >>> and Darwin (see gdb/configure.nat). I am a bit concerned that >>> linux-ptrace.h could use some Linux-specific things, and thus would >>> break the other builds. However, I built-tested on FreeBSD and it seems >>> fine. Worst case, we can probably wrap this include in "#ifdef >>> __linux__" if that becomes a problem. >> >> Or better, this horrible mess of __UCLIBC__ and HAS_NOMMU macros should >> be replaced by a proper autoconf check testing for the availability of >> fork(). > > Agreed, and I think Pedro will agree too (unless you can think of a simpler solution that doesn't involve autoconf?). That does sound better. Thanks, Pedro Alves
diff --git a/gdb/nat/fork-inferior.c b/gdb/nat/fork-inferior.c index 8b59387fa5..05167628a6 100644 --- a/gdb/nat/fork-inferior.c +++ b/gdb/nat/fork-inferior.c @@ -26,6 +26,7 @@ #include "common-gdbthread.h" #include "signals-state-save-restore.h" #include "gdb_tilde_expand.h" +#include "linux-ptrace.h" #include <vector> extern char **environ;