diff mbox

Backport of patch to gdb 8.0 branch.

Message ID 20180518094554.GA18416@arm.com
State New, archived
Headers

Commit Message

Tamar Christina May 18, 2018, 9:45 a.m. UTC 
  Hi Joel,

The build with debug tracing enabled (`-DDEBUG_AARCH64`)
is currently broken. A variable that no longer exists is being
referenced from the debug statement.

Compiled on aarch64-none-linux-gnu and no issues,


This patch already exists in master and 8.1 branches as
957f6b39cab6cac0e4c54e650c7f75109544ac1d.

Ok for gdb-8.0-branch?

opcodes/
2018-05-18  Tamar Christina  <tamar.christina@arm.com>

	PR gdb/23200
	* aarch64-opc.c (aarch64_logical_immediate_p): Update
	DEBUG_TRACE arguments.

Thanks,
Tamar

The 05/17/2018 18:16, Joel Brobecker wrote:
> > I'm looking for a backport of
> > https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=957f6b39cab6cac0e4c54e650c7f75109544ac1d
> > to the gdb-8.0-branch. The patch allows building with full debug trace
> > enabled on AArch64.
> > 
> > Ok for gdb-8.0-branch?
> 
> If not already done so, please create a PR in bugzilla that explains
> the problem this patch is fixing. Once this is done, can you add that
> PR number to the ChangeLog and revision log of the commit you'd like
> to backport?
> 
> Here is an example that shows a PR with associated commits:
> https://sourceware.org/bugzilla/show_bug.cgi?id=22849
> 
> This is to follow part of our procedures aiming at properly documenting
> all changes that go into a release branch after we make the first
> release on that branch.
> 
> -- 
> Joel

--

Comments

Joel Brobecker May 18, 2018, 5 p.m. UTC | #1 
> This patch already exists in master and 8.1 branches as
> 957f6b39cab6cac0e4c54e650c7f75109544ac1d.
> 
> Ok for gdb-8.0-branch?
> 
> opcodes/
> 2018-05-18  Tamar Christina  <tamar.christina@arm.com>
> 
> 	PR gdb/23200
> 	* aarch64-opc.c (aarch64_logical_immediate_p): Update
> 	DEBUG_TRACE arguments.

Yes, you can go right ahead.


> diff --git a/opcodes/aarch64-opc.c b/opcodes/aarch64-opc.c
> index cc99c101236c542ff94bb9c0abc09df521ced330..a52ea70c0093f7daaecfd58e3f0e81a3953abf5f 100644
> --- a/opcodes/aarch64-opc.c
> +++ b/opcodes/aarch64-opc.c
> @@ -1204,8 +1204,8 @@ aarch64_logical_immediate_p (uint64_t value, int esize, aarch64_insn *encoding)
>    uint64_t upper;
>    int i;
>  
> -  DEBUG_TRACE ("enter with 0x%" PRIx64 "(%" PRIi64 "), is32: %d", value,
> -	       value, is32);
> +  DEBUG_TRACE ("enter with 0x%" PRIx64 "(%" PRIi64 "), esize: %d", value,
> +	       value, esize);
>  
>    if (initialized == FALSE)
>      {
>
diff mbox

Patch

diff --git a/opcodes/aarch64-opc.c b/opcodes/aarch64-opc.c
index cc99c101236c542ff94bb9c0abc09df521ced330..a52ea70c0093f7daaecfd58e3f0e81a3953abf5f 100644
--- a/opcodes/aarch64-opc.c
+++ b/opcodes/aarch64-opc.c
@@ -1204,8 +1204,8 @@  aarch64_logical_immediate_p (uint64_t value, int esize, aarch64_insn *encoding)
   uint64_t upper;
   int i;
 
-  DEBUG_TRACE ("enter with 0x%" PRIx64 "(%" PRIi64 "), is32: %d", value,
-	       value, is32);
+  DEBUG_TRACE ("enter with 0x%" PRIx64 "(%" PRIi64 "), esize: %d", value,
+	       value, esize);
 
   if (initialized == FALSE)
     {