diff mbox

gdb: Add test for some error cases of @entry usage

Message ID 20180121000151.29174-1-andrew.burgess@embecosm.com
State New
Headers show

Commit Message

Andrew Burgess Jan. 21, 2018, 12:01 a.m. UTC
Adds a test that using @entry for a non-parameter, or for an unknown
symbol, both give the expected error.  This error message was
previously untested.

gdb/testsuite/ChangeLog:

	* gdb.arch/amd64-entry-value.exp: Test using @entry on a
	non-parameter, and on an unknown symbol.
---
 gdb/testsuite/ChangeLog                      | 5 +++++
 gdb/testsuite/gdb.arch/amd64-entry-value.exp | 8 ++++++++
 2 files changed, 13 insertions(+)

Comments

Pedro Alves Jan. 21, 2018, 12:46 a.m. UTC | #1
On 01/21/2018 12:01 AM, Andrew Burgess wrote:
> Adds a test that using @entry for a non-parameter, or for an unknown
> symbol, both give the expected error.  This error message was
> previously untested.
> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.arch/amd64-entry-value.exp: Test using @entry on a
> 	non-parameter, and on an unknown symbol.

OK.  Thanks!

Pedro Alves
diff mbox

Patch

diff --git a/gdb/testsuite/gdb.arch/amd64-entry-value.exp b/gdb/testsuite/gdb.arch/amd64-entry-value.exp
index 46a896fdec0..72700d55c23 100644
--- a/gdb/testsuite/gdb.arch/amd64-entry-value.exp
+++ b/gdb/testsuite/gdb.arch/amd64-entry-value.exp
@@ -87,6 +87,14 @@  gdb_test "p d9@entry" " = 11\\.5" "entry_stack: p d9@entry"
 gdb_test "p da" " = 4\\.5" "entry_stack: p da"
 gdb_test "p da@entry" " = 12\\.5" "entry_stack: p da@entry"
 
+# Test @entry values for a static file scoped variable, and for an
+# unknown symbol.  Both of these should give an error.
+gdb_test "p v@entry" \
+    "@entry can be used only for function parameters, not for \"v\"" \
+    "attempt to print global v@entry"
+gdb_test "p unknown@entry" \
+    "@entry can be used only for function parameters, not for \"unknown\"" \
+    "attempt to print unknown@entry"
 
 # Test various kinds of `set print entry-values'.