Message ID | 1506092746-17214-1-git-send-email-simon.marchi@ericsson.com |
---|---|
State | New, archived |
Headers |
Received: (qmail 69472 invoked by alias); 22 Sep 2017 15:06:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <gdb-patches.sourceware.org> List-Unsubscribe: <mailto:gdb-patches-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/gdb-patches/> List-Post: <mailto:gdb-patches@sourceware.org> List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 69104 invoked by uid 89); 22 Sep 2017 15:06:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3 autolearn=ham version=3.3.2 spammy=Description X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Sep 2017 15:06:01 +0000 Received: from ESESSHC013.ericsson.se (Unknown_Domain [153.88.183.57]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 02.25.20899.7D625C95; Fri, 22 Sep 2017 17:05:59 +0200 (CEST) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.57) with Microsoft SMTP Server (TLS) id 14.3.352.0; Fri, 22 Sep 2017 17:05:58 +0200 Received: from elxacz23q12.ki.sw.ericsson.se (192.176.1.80) by AMSPR07MB309.eurprd07.prod.outlook.com (2a01:111:e400:802f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Fri, 22 Sep 2017 15:05:57 +0000 From: Simon Marchi <simon.marchi@ericsson.com> To: <gdb-patches@sourceware.org> CC: <qiyaoltc@gmail.com>, Simon Marchi <simon.marchi@ericsson.com> Subject: [PATCH] nto & lynx x86: call init_target_desc Date: Fri, 22 Sep 2017 17:05:46 +0200 Message-ID: <1506092746-17214-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain X-ClientProxiedBy: HE1PR0101CA0011.eurprd01.prod.exchangelabs.com (2603:10a6:3:77::21) To AMSPR07MB309.eurprd07.prod.outlook.com (2a01:111:e400:802f::12) X-MS-Office365-Filtering-Correlation-Id: 2f5f7c42-bc44-45e2-d0d9-08d501cb6de8 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:AMSPR07MB309; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB309; 3:h9VSEenq/hkbgNYW6idcJ9qIlAkUQd8R4FWVUtKKACQpAc3LJqhSLkP34tfbXPuO/mEoUcs7nXakDfOnUMslbSfQ8rDCleyu8PhVLLss2xZ2nDFQGezpld12zy89Is15AzSIf60az6XlfOGR9nRQbL8swRGgFDDbe6vXMueafDbFfX2gufxz0ExRnWIY8ekwC9LHLWUJiMQQoCGPC0rdhkiE3DfoyU/WoSKWqP2zRE5Os9GWHadbYEbOUZmRd8st; 25:/XhArTLHZC7jIMcmBwBKII65sBWZyNQju9wkd809wuWSPv7a5mNCdWIzGHCJ/xuH1InzCa9S0rbR7oKI9qXB24nrbyHl6qhQ2gqorHL0b/kQn1nTi7w+A/QSeN2vvfIBi/fkPNEqOBcvspFp1kkf524d+Le3s/okQ0zxRsAHK++vpQoAoPcQnfHdIfxEHUJHHErkP7lpH3ELTSv4jSksRN0aNH66qJnmbQrDiE9Kj3M1XvW6xhjPlIkRTO4sE6zW+qQiRIoaJkOV/6ZhX9QgdfR2Rgk+JqqCCDmm0+N5F/OD3YIfezZIAH3837xks4tEEmC3z/ZaPl7yhB2WGX/jcQ==; 31:YEyOCxA8qqKIAxQthS6y8Z3TJ+7Zo5pfKDiMgaPwXELpQ5XSYJsXSeiaPlviA/1IN331BOswqHGLyOIEbFgkVozRvDygOeiugs6mRFJeC2cC8YSo7w6R6KHYKdeqIM17IgwPXdBLHJgU/IwOjF1CnLJSoDg47ipLGwInYxldzjoO6Wz87XQW3z4lAc3EQdruvgJiRXZSr/okC0Ngua8nIpuV3xdygmt/RyW+4T+DLzw= X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMSPR07MB309: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB309; 20:JxlWP/hhMOZ7fla5MNMkU7cff8MP4/wFJwfH+LUhPZv+dJhW7f2kWM2m5lrcY5LnQRr51+vev60WGyeVcPnvl9qgt2T1Qha/WtQ5e59/KNyozaWjp33mnRGnui0WkYxMRWXxuXvOqRaG5NVS2zfjqCpZ77SlCxEHl5q25KpL1euWOryYwDRP8rC+9t9E0UePL8B8wXPgo+0NEd+FsaeVeziW/sfq5iA34pREb8Kz7Mb3oHSIg3oBav1lvrmFjCwX95NtxqIUwKqxuYWSe1qBtBV6tfKznKemdxLgpSLNjvZCnuMcJd0qfXvQSGV/pS/nGxw9SF7ppvgQRjDAa5Kn3M222Ff+wSGvtEXZXPzgUtsom1IhfkfGiA00QwjBbC+cGu3ICY1iNYAGE6m9d/GeCVPnVKbfnM2UznFH3QoGVK2X3lMqTfYfrVWAdgs132+Ru1YJO4xifE+SuXB25PCACvElxJOK04VZW+1nIZL3c7akgqlTS+cGxwbubKsgl9ZY; 4:HN7JZ4zElHdSghFhB0y5c44GrFne2uZnsk2zZL4WVbFeggKIPyjUVDk7WEB64eewNT0SOqfvm9cIZ8AdBKDyMXRXQpOXWMEFWkqm6gOA2DyPnCHP4uuM1D3NrYTiEjZcmEtT6IM/jCEWBbzRabpmxMRw5wVEAj/Gchr2buRzYsRG3k7P+MeV1voxJJINMn4d4A3iaW/kar5CEGVHW+j1Mtz0u3Nmoh0A3kcnIdBcOoGx61ovZXZQgEbb54SnMYj9 X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: <AMSPR07MB3097F15EA138C88A46B60EFED670@AMSPR07MB309.eurprd07.prod.outlook.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:AMSPR07MB309; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:AMSPR07MB309; X-Forefront-PRVS: 0438F90F17 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6009001)(376002)(346002)(39860400002)(189002)(43544003)(199003)(54534003)(50226002)(81156014)(8936002)(8676002)(36756003)(3846002)(68736007)(5003940100001)(189998001)(81166006)(50986999)(305945005)(7736002)(86362001)(6116002)(101416001)(5660300001)(33646002)(2351001)(106356001)(105586002)(66066001)(50466002)(107886003)(25786009)(4326008)(6916009)(39060400002)(6666003)(16526017)(478600001)(16586007)(6512007)(48376002)(316002)(97736004)(6486002)(6506006)(2906002)(53936002)(2361001)(47776003); DIR:OUT; SFP:1101; SCL:1; SRVR:AMSPR07MB309; H:elxacz23q12.ki.sw.ericsson.se; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AMSPR07MB309; 23:qqlZWlVCut775K6gNWrKmoRKh2NW36ZrhnUKNhQRJG?= =?us-ascii?Q?u48ffxIpgU60EoNdQlUoDfKTw1ReF1d3st4TjLXQKz1NqwK+EPiO57Vg4Q1o?= =?us-ascii?Q?Vce0ebDb5GoHxYr7M5tGTPaGpYxpIZyldQBqr9R/GYtSU8diK6ZA4KlQFaGT?= =?us-ascii?Q?sr9r0EO5Nn8tIzK7iz1mgjVmqNkT9Vda5uoAFnyKnj8q9CSGqjwcfYFTpHPs?= =?us-ascii?Q?yWBcDOb8q4sTR3zkMiSlP3ht8XQSowNfIN6L57HYt1OIvw4ozhYiM163CqUx?= =?us-ascii?Q?jWzpXX2psAT1+76ynwdhTxrvzBrlWdVQk+ohqfFah/QuK1rSzSDHilK2zp2F?= =?us-ascii?Q?7lJ3Fb5PyoA/yUEl6AYSeWEBxMjmnyTpVDKuJALDnia+s21Uob6Aaz5WmaKx?= =?us-ascii?Q?DPuuUoKps3zloTeDJcWIi8uoQ99dpYaWuchlIm4GM125EAzhWkv5bcgDIliE?= =?us-ascii?Q?5otYN3+NyowLI/rcDBxlVRTBcGxTosVEYb4JQFoiAGJ+QBzu7HSrH3HTcaVa?= =?us-ascii?Q?kvNbcKyVK5yM4Imnb1FF93o6Ua+iThQzx+R4RUnjf5LTTp5/cZtMkxSvMSs1?= =?us-ascii?Q?CINV51Amual7F9s2m7CBWXHD/BfBsCxvWvAWSe1bpnSp5xE+cloy0Tz1qfyP?= =?us-ascii?Q?MKUCmRF+XXlKIyio9uV+BymDsli62t0+zqrH8aP4cX33zPTUPnUMiOqwPxvb?= =?us-ascii?Q?qcbExh5aHeGoXW1NuGJquJWpIwEkqyf3klyvemcvx3+BKK7ofpkRH6lsRGUL?= =?us-ascii?Q?gvSdHdOMvZjDfO1o02EctSBBJBsJWAm0FXTJxyTfMubZndzr2uMC6AJzK1e+?= =?us-ascii?Q?qoiSc7xDcUVArLVIuj+Q6ck+r2T+rAdv6jzN2+gqtsYuTTHodYqiSPZvJ20F?= =?us-ascii?Q?gHL2ZxH+j1WmnjDuypWsbFJnmX50+gsUtIn8By+walGsCHUu7RmxDQjZmydN?= =?us-ascii?Q?xWJPLOEyHdm90Eb55XPaqtW1ISuo6hF2FNlPdsF0U67EZtqQR3ICXYLu+weX?= =?us-ascii?Q?CTih5mkOQbor58wf1dhNWh0OE5PKk4+fTrlozjQb1nW3gadivFOQHQt6diAX?= =?us-ascii?Q?zogqHy/cjcofhocEVBWztbfFz37tJ0JnaiyZKjvjAHBg40v6pzIyQbP8ky77?= =?us-ascii?Q?cxhuU4jnH9tu8SOb1Pl0WszgeHcwZru73KTRek6i0Sgg075Td2RprwQuZ2Bx?= =?us-ascii?Q?Ay09RlXU4L46E=3D?= X-Microsoft-Exchange-Diagnostics: 1; AMSPR07MB309; 6:VRxVI+CmZoJg+4xroqB+MoLwfk2NhKKWpwxbzhm5v/bz2GBluyvRAAtv+0u8uoZHRdpIfDNWTJcVpMYqNCrRdTOtcSVuBUK3LIjPe59rsNTQkySxpcnFC2n/9dthtMPS33o9Z+UAhPjd9G0E2k7Ikz4sg3vtAiMXQJr518RYYWVp3Pcq3g0oRqOj1KUadEz+vDdEjwPYrDyNgtYhaadjii+Cmyuj5Xb4PJLTEnoBPRonFhCfLgmX9BSRw+PPZLENm1GWOlVwRWd9ms+nEFxVh2lR4RVAs7+b1q39W3gqlYITcxmf+43IqB/IcpanIjPc79PoexU5fmqnpXiH1mXSXA==; 5:QKE/c+qLogKKQXUI84o13M4MAv97f+KYeoRIIBgjpxKBeil1mmY4OFXfWYnq4mk/t5FIGf92OBZfFRhl9tzenW+a6ktFmtpqliNpbHeC8SkDc1i8UoD2BEp+KqLhV1dPQDKbbE6+sAHuz/XbZ5iiQg==; 24:QOh+0hghpvckqqMP7gwGKxgMolB+RSxv9ZZ/87/Nwa4wVccmz5C5PRFdhCJHxODVUpdSKZk1cLzS7WvJMSwfr1jbsHPmgwX4xVBoiwRP1ME=; 7:vvyC+JW72RJohlTFl+1QeH7Opo/mlX+J2AYCRR9d1LXB0GQP1kf3jfWB0DzDAq0dWLC1Ed+4cvomVWn53JpuyMogWTvCsH4VIZfgau1wL+hkwEsZWriIDOXg7qosIBXznVPYmjJyjt7vudh50wM60ikFSdN6zMitA4biXwigNuxWjBtUhUpt/R6lItB8EDLn8Y4CxwhChdE8Sj4eXX9ot+RlCCvD3Sjo4Mm13tVeCMo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2017 15:05:57.4725 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB309 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes |
Commit Message
Simon Marchi
Sept. 22, 2017, 3:05 p.m. UTC
In gdbserver, target descriptions need to be initialized by calling init_target_desc. Because i386_create_target_description is shared with GDB, it doesn't do that, the callers must take care of it. These two platforms currently don't. I am not able to build them, so I couldn't test. gdb/gdbserver/ChangeLog: * lynx-i386-low.c (lynx_i386_arch_setup): Call init_target_desc. * nto-x86-low.c (nto_x86_arch_setup): Likewise. --- gdb/gdbserver/lynx-i386-low.c | 7 ++++++- gdb/gdbserver/nto-x86-low.c | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-)
Comments
Hi Simon, On Fri, Sep 22, 2017 at 05:05:46PM +0200, Simon Marchi wrote: > In gdbserver, target descriptions need to be initialized by calling > init_target_desc. Because i386_create_target_description is shared with > GDB, it doesn't do that, the callers must take care of it. These two > platforms currently don't. > > I am not able to build them, so I couldn't test. > > gdb/gdbserver/ChangeLog: > > * lynx-i386-low.c (lynx_i386_arch_setup): Call init_target_desc. > * nto-x86-low.c (nto_x86_arch_setup): Likewise. For LynxOS, go right ahead. I haven't been able to build GDBserver on LynxOS ever since we switched to C++, as there is no satisfactory C++ compiler on this platform that I could find or build. I'm hoping this will change sometime, but in the meantime, best effort is the best we can do... In this case, it looks quite reasonable. Thanks for doing that.
On 2017-09-22 17:14, Joel Brobecker wrote: > Hi Simon, > > On Fri, Sep 22, 2017 at 05:05:46PM +0200, Simon Marchi wrote: >> In gdbserver, target descriptions need to be initialized by calling >> init_target_desc. Because i386_create_target_description is shared >> with >> GDB, it doesn't do that, the callers must take care of it. These two >> platforms currently don't. >> >> I am not able to build them, so I couldn't test. >> >> gdb/gdbserver/ChangeLog: >> >> * lynx-i386-low.c (lynx_i386_arch_setup): Call init_target_desc. >> * nto-x86-low.c (nto_x86_arch_setup): Likewise. > > For LynxOS, go right ahead. I haven't been able to build GDBserver > on LynxOS ever since we switched to C++, as there is no satisfactory > C++ compiler on this platform that I could find or build. I'm hoping > this will change sometime, but in the meantime, best effort is the > best we can do... In this case, it looks quite reasonable. > > Thanks for doing that. Thanks, I'll push the patch as-is then. Simon
diff --git a/gdb/gdbserver/lynx-i386-low.c b/gdb/gdbserver/lynx-i386-low.c index 57181d6..a7eae1d 100644 --- a/gdb/gdbserver/lynx-i386-low.c +++ b/gdb/gdbserver/lynx-i386-low.c @@ -293,7 +293,12 @@ lynx_i386_store_fpregset (struct regcache *regcache, const char *buf) static void lynx_i386_arch_setup (void) { - lynx_tdesc = i386_create_target_description (X86_XSTATE_SSE_MASK, false); + struct target_desc *tdesc + = i386_create_target_description (X86_XSTATE_SSE_MASK, false); + + init_target_desc (tdesc); + + lynx_tdesc = tdesc; } /* Description of all the x86-lynx register sets. */ diff --git a/gdb/gdbserver/nto-x86-low.c b/gdb/gdbserver/nto-x86-low.c index cfa5993..48bdc53 100644 --- a/gdb/gdbserver/nto-x86-low.c +++ b/gdb/gdbserver/nto-x86-low.c @@ -87,7 +87,12 @@ static void nto_x86_arch_setup (void) { the_low_target.num_regs = 16; - nto_tdesc = i386_create_target_description (X86_XSTATE_SSE_MASK, false); + struct target_desc *tdesc + = i386_create_target_description (X86_XSTATE_SSE_MASK, false); + + init_target_desc (tdesc); + + nto_tdesc = tdesc; } struct nto_target_ops the_low_target =