diff mbox

Fix obvious gotcha in string comparison

Message ID 1477345919-32239-1-git-send-email-lgustavo@codesourcery.com
State New, archived
Headers

Commit Message

Luis Machado Oct. 24, 2016, 9:51 p.m. UTC 
  This patch fixes a gotcha when comparing exception's messages in
exception_print_same. It should've used the statically-allocated
string versions msg1 and msg2 instead.

As is, it could lead to crashes.

gdb/ChangeLog:
2016-10-24  Luis Machado  <lgustavo@codesourcery.com>

	* exec.c (exception_print_same): Fix string comparison to use
	statically-allocated ones.
---
 gdb/ChangeLog | 5 +++++
 gdb/exec.c    | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

Comments

Pedro Alves Oct. 24, 2016, 10:25 p.m. UTC | #1 
OK.

Thanks,
Pedro Alves
Luis Machado Oct. 24, 2016, 10:45 p.m. UTC | #2 
On 10/24/2016 05:25 PM, Pedro Alves wrote:
> OK.
>
> Thanks,
> Pedro Alves
>

Thanks, pushed as 010ece9c47f1ac08c9436b133a74472713dd709b.
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index be72369..388cc1f 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@ 
+2016-10-24  Luis Machado  <lgustavo@codesourcery.com>
+
+	* exec.c (exception_print_same): Fix string comparison to use
+	statically-allocated ones.
+
 2016-10-21  Tom Tromey  <tom@tromey.com>
 
 	* dwarf2expr.h (class dwarf_expr_context)
diff --git a/gdb/exec.c b/gdb/exec.c
index d858e99..67ecc63 100644
--- a/gdb/exec.c
+++ b/gdb/exec.c
@@ -152,7 +152,7 @@  exception_print_same (struct gdb_exception e1, struct gdb_exception e2)
 
   return (e1.reason == e2.reason
 	  && e1.error == e2.error
-	  && strcmp (e1.message, e2.message) == 0);
+	  && strcmp (msg1, msg2) == 0);
 }
 
 /* See gdbcore.h.  */