diff mbox

[02/10] Garbage collect window_hook

Message ID 1455817236-13642-3-git-send-email-palves@redhat.com
State New, archived
Headers

Commit Message

Pedro Alves Feb. 18, 2016, 5:40 p.m. UTC 
  I checked, and Insight doesn't set this.

gdb/ChangeLog:
2016-02-18  Pedro Alves  <palves@redhat.com>

	* top.c (window_hook): Delete.
	(command_loop): Remove references to window_hook.
---
 gdb/top.c | 9 ---------
 1 file changed, 9 deletions(-)

Comments

Sergio Durigan Junior Feb. 18, 2016, 9:55 p.m. UTC | #1 
On Thursday, February 18 2016, Pedro Alves wrote:

> I checked, and Insight doesn't set this.
>
> gdb/ChangeLog:
> 2016-02-18  Pedro Alves  <palves@redhat.com>
>
> 	* top.c (window_hook): Delete.
> 	(command_loop): Remove references to window_hook.
> ---
>  gdb/top.c | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/gdb/top.c b/gdb/top.c
> index ed200ba..b5ee4af 100644
> --- a/gdb/top.c
> +++ b/gdb/top.c
> @@ -124,12 +124,6 @@ char *current_directory;
>  /* The directory name is actually stored here (usually).  */
>  char gdb_dirbuf[1024];
>  
> -/* Function to call before reading a command, if nonzero.
> -   The function receives two args: an input stream,
> -   and a prompt string.  */
> -
> -void (*window_hook) (FILE *, char *);
> -
>  /* Buffer used for reading command lines, and the size
>     allocated for it so far.  */
>  
> @@ -545,9 +539,6 @@ command_loop (void)
>  
>    while (instream && !feof (instream))
>      {
> -      if (window_hook && instream == stdin)
> -	(*window_hook) (instream, get_prompt ());
> -
>        clear_quit_flag ();
>        if (instream == stdin)
>  	reinitialize_more_filter ();
> -- 
> 1.9.3

LGTM.

Thanks,
diff mbox

Patch

diff --git a/gdb/top.c b/gdb/top.c
index ed200ba..b5ee4af 100644
--- a/gdb/top.c
+++ b/gdb/top.c
@@ -124,12 +124,6 @@  char *current_directory;
 /* The directory name is actually stored here (usually).  */
 char gdb_dirbuf[1024];
 
-/* Function to call before reading a command, if nonzero.
-   The function receives two args: an input stream,
-   and a prompt string.  */
-
-void (*window_hook) (FILE *, char *);
-
 /* Buffer used for reading command lines, and the size
    allocated for it so far.  */
 
@@ -545,9 +539,6 @@  command_loop (void)
 
   while (instream && !feof (instream))
     {
-      if (window_hook && instream == stdin)
-	(*window_hook) (instream, get_prompt ());
-
       clear_quit_flag ();
       if (instream == stdin)
 	reinitialize_more_filter ();