gdb.trace: Bump tspeed.exp timeout to 600 seconds.
Commit Message
It seems the 180 seconds timeout is quite tight on my z13 machine,
and causes failures when the machine is somewhat loaded.
gdb/testsuite/ChangeLog:
* gdb.trace/tspeed.exp: Bump the timeout to 600 seconds.
---
Whoops, changing to 600. 300 was quite enough for me, and what I initially
selected, but I figured it'd be good to leave some more headroom for slower
machines.
gdb/testsuite/ChangeLog | 4 ++++
gdb/testsuite/gdb.trace/tspeed.exp | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
Comments
Marcin Kościelnicki <koriakin@0x04.net> writes:
> # Typically we need a little extra time for this test.
> -set timeout 180
> +set timeout 600
Alternatively, you can wrap the slow test with with_timeout_factor.
On 29/01/16 10:53, Marcin Kościelnicki wrote:
> It seems the 180 seconds timeout is quite tight on my z13 machine,
> and causes failures when the machine is somewhat loaded.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.trace/tspeed.exp: Bump the timeout to 600 seconds.
> ---
I've since learned of an earlier unpushed patch solving the same issue:
https://sourceware.org/ml/gdb-patches/2015-08/msg00658.html . Since it
seems to be a smarter fix than mine, I'd like to abandon this patch.
@@ -1,5 +1,9 @@
2016-01-24 Marcin Kościelnicki <koriakin@0x04.net>
+ * gdb.trace/tspeed.exp: Bump the timeout to 600 seconds.
+
+2016-01-24 Marcin Kościelnicki <koriakin@0x04.net>
+
* gdb.trace/ftrace.exp: Select $r2 as test register for s390.
* gdb.trace/mi-trace-frame-collected.exp: Expect 2 registers on s390.
* gdb.trace/trace-common.h (x86_trace_dummy): Add s390 fast tracepoint
@@ -27,7 +27,7 @@ if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
}
# Typically we need a little extra time for this test.
-set timeout 180
+set timeout 600
set ws "\[\r\n\t \]+"
set cr "\[\r\n\]+"