[c++,1/6] dwarf2read.c: Add cast

  There is no enum value representing 0.  It seems like the value of the
name field is irrelevant here.

gdb/ChangeLog:

	* dwarf2read.c (partial_die_full_name): Add cast.
---
 gdb/dwarf2read.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

On 29 October 2015 at 09:02, Simon Marchi <simon.marchi@polymtl.ca> wrote:
> There is no enum value representing 0.  It seems like the value of the
> name field is irrelevant here.
>
> gdb/ChangeLog:
>
>         * dwarf2read.c (partial_die_full_name): Add cast.
> ---
>  gdb/dwarf2read.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
> index d43c42e..baa288c 100644
> --- a/gdb/dwarf2read.c
> +++ b/gdb/dwarf2read.c
> @@ -6854,7 +6854,7 @@ partial_die_full_name (struct partial_die_info *pdi,
>           struct dwarf2_cu *ref_cu = cu;
>
>           /* DW_FORM_ref_addr is using section offset.  */
> -         attr.name = 0;
> +         attr.name = (dwarf_attribute) 0;

Oops, here it should say (enum dwarf_attribute), so it works in C too.

>           attr.form = DW_FORM_ref_addr;
>           attr.u.unsnd = pdi->offset.sect_off;
>           die = follow_die_ref (NULL, &attr, &ref_cu);
> --
> 2.6.1
>
  

On 10/29/2015 02:57 PM, Simon Marchi wrote:

>> --- a/gdb/dwarf2read.c
>> +++ b/gdb/dwarf2read.c
>> @@ -6854,7 +6854,7 @@ partial_die_full_name (struct partial_die_info *pdi,
>>           struct dwarf2_cu *ref_cu = cu;
>>
>>           /* DW_FORM_ref_addr is using section offset.  */
>> -         attr.name = 0;
>> +         attr.name = (dwarf_attribute) 0;
> 
> Oops, here it should say (enum dwarf_attribute), so it works in C too.

OK with that change.

Thanks,
Pedro Alves
  

On 29 October 2015 at 13:14, Pedro Alves <palves@redhat.com> wrote:
> On 10/29/2015 02:57 PM, Simon Marchi wrote:
>
>>> --- a/gdb/dwarf2read.c
>>> +++ b/gdb/dwarf2read.c
>>> @@ -6854,7 +6854,7 @@ partial_die_full_name (struct partial_die_info *pdi,
>>>           struct dwarf2_cu *ref_cu = cu;
>>>
>>>           /* DW_FORM_ref_addr is using section offset.  */
>>> -         attr.name = 0;
>>> +         attr.name = (dwarf_attribute) 0;
>>
>> Oops, here it should say (enum dwarf_attribute), so it works in C too.
>
> OK with that change.
>
> Thanks,
> Pedro Alves

Pushed everything except patch 2, thanks!