diff mbox

Fix --host cris-*-linux build of GDBServer.

Message ID 1445369050-18033-1-git-send-email-antoine.tremblay@ericsson.com
State New, archived
Headers

Commit Message

Antoine Tremblay Oct. 20, 2015, 7:24 p.m. UTC 
  Compiling GDBServer with --host cris-*-linux yields a compilation error :

linux-cris-low.c:65:21: error: ‘void’ must be the only parameter

This patch fixes the issue by removing the void parameter in cris_get_pc.

gdb/gdbserver/ChangeLog:
	* linux-cris-low.c (cris_get_pc): Remove void arg.
---
 gdb/gdbserver/linux-cris-low.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Yao Qi Oct. 21, 2015, 8:18 a.m. UTC | #1 
On 20/10/15 20:24, Antoine Tremblay wrote:
> Compiling GDBServer with --host cris-*-linux yields a compilation error :
>
> linux-cris-low.c:65:21: error: ‘void’ must be the only parameter
>
> This patch fixes the issue by removing the void parameter in cris_get_pc.
>
> gdb/gdbserver/ChangeLog:
> 	* linux-cris-low.c (cris_get_pc): Remove void arg.

The change is obvious, and patch is OK to me.  Thanks for splitting
it out of your ARM GDBserver breakpoint patches.
Antoine Tremblay Oct. 21, 2015, 11:49 a.m. UTC | #2 
On 10/21/2015 04:18 AM, Yao Qi wrote:
> On 20/10/15 20:24, Antoine Tremblay wrote:
>> Compiling GDBServer with --host cris-*-linux yields a compilation error :
>>
>> linux-cris-low.c:65:21: error: ‘void’ must be the only parameter
>>
>> This patch fixes the issue by removing the void parameter in cris_get_pc.
>>
>> gdb/gdbserver/ChangeLog:
>>     * linux-cris-low.c (cris_get_pc): Remove void arg.
>
> The change is obvious, and patch is OK to me.  Thanks for splitting
> it out of your ARM GDBserver breakpoint patches.
>

Pushed. Yes, it's obvious I guess I'm overly cautious.
diff mbox

Patch

diff --git a/gdb/gdbserver/linux-cris-low.c b/gdb/gdbserver/linux-cris-low.c
index e0bfa1a..135e37a 100644
--- a/gdb/gdbserver/linux-cris-low.c
+++ b/gdb/gdbserver/linux-cris-low.c
@@ -62,7 +62,7 @@  cris_cannot_fetch_register (int regno)
 extern int debug_threads;
 
 static CORE_ADDR
-cris_get_pc (struct regcache *regcache, void)
+cris_get_pc (struct regcache *regcache)
 {
   unsigned long pc;
   collect_register_by_name (regcache, "pc", &pc);