diff mbox

[v2] gdb: Remove support for old mangling schemes

Message ID 0da7933d5fb99c0c390acb5482cdcde7@polymtl.ca
State New, archived
Headers

Commit Message

Simon Marchi Jan. 9, 2019, 3:59 p.m. UTC 
  On 2019-01-09 10:39, Eli Zaretskii wrote:
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>> Cc: Simon Marchi <simon.marchi@ericsson.com>
>> Date: Tue,  8 Jan 2019 23:50:32 -0500
>> 
>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>> index 4bca933195c9..ffc702937b7a 100644
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -10703,31 +10703,9 @@ or demangled form.
>>  @cindex symbol decoding style, C@t{++}
>>  @kindex set demangle-style
>>  @item set demangle-style @var{style}
>> -Choose among several encoding schemes used by different compilers to
>> -represent C@t{++} names.  The choices for @var{style} are currently:
>> -
>> -@table @code
>> -@item auto
>> -Allow @value{GDBN} to choose a decoding style by inspecting your 
>> program.
>> -This is the default.
> 
> Are we removing 'auto' as well?  If not, why do we want to un-document
> it?

I decided to remove the list of possible values and refer to the 
in-process help, this way we don't have to keep it up to date (as you 
might notice, the list was incomplete).  But since the value "auto" is 
special, I agree we should mention it.  Is it fine if I add this 
sentence?


  @item show demangle-style
  Display the encoding style currently in use for decoding C@t{++} 
symbols.

Simon

Comments

Eli Zaretskii Jan. 9, 2019, 4:14 p.m. UTC | #1 
> Date: Wed, 09 Jan 2019 10:59:14 -0500
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Cc: gdb-patches@sourceware.org
> 
> > Are we removing 'auto' as well?  If not, why do we want to un-document
> > it?
> 
> I decided to remove the list of possible values and refer to the 
> in-process help, this way we don't have to keep it up to date (as you 
> might notice, the list was incomplete).  But since the value "auto" is 
> special, I agree we should mention it.  Is it fine if I add this 
> sentence?

Yes, thanks.
Simon Marchi Jan. 9, 2019, 4:18 p.m. UTC | #2 
On 2019-01-09 11:14, Eli Zaretskii wrote:
>> Date: Wed, 09 Jan 2019 10:59:14 -0500
>> From: Simon Marchi <simon.marchi@polymtl.ca>
>> Cc: gdb-patches@sourceware.org
>> 
>> > Are we removing 'auto' as well?  If not, why do we want to un-document
>> > it?
>> 
>> I decided to remove the list of possible values and refer to the
>> in-process help, this way we don't have to keep it up to date (as you
>> might notice, the list was incomplete).  But since the value "auto" is
>> special, I agree we should mention it.  Is it fine if I add this
>> sentence?
> 
> Yes, thanks.

Thanks.  I'll just wait for the confirmation from Keith that v2 is ok 
with him before pushing.

Simon
Keith Seitz Jan. 9, 2019, 5:02 p.m. UTC | #3 
On 1/9/19 8:18 AM, Simon Marchi wrote:
> I'll just wait for the confirmation from Keith that v2 is ok with him
> before pushing.
Absolutely! Please, approve your patch! ;-)

Keith
Simon Marchi Jan. 9, 2019, 6:08 p.m. UTC | #4 
On 2019-01-09 12:02, Keith Seitz wrote:
> On 1/9/19 8:18 AM, Simon Marchi wrote:
>> I'll just wait for the confirmation from Keith that v2 is ok with him
>> before pushing.
> Absolutely! Please, approve your patch! ;-)

Thanks, it's now pushed.

Simon
diff mbox

Patch

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index ffc702937b7..4a00834d0bf 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -10705,7 +10705,8 @@  or demangled form.
  @item set demangle-style @var{style}
  Choose among several encoding schemes used by different compilers to 
represent
  C@t{++} names.  If you omit @var{style}, you will see a list of 
possible
-formats.
+formats.  The default value is @var{auto}, which lets @value{GDBN} 
choose a
+decoding style by inspecting your program.