diff mbox

[Bug,win32/14529] Make gdb capable of JIT-debugging on W32

Message ID 0896c322-0ac9-b60e-daaf-09355307e19b@gmail.com
State New, archived
Headers

Commit Message

LRN June 30, 2016, 7:13 p.m. UTC 
  On 30.06.2016 21:56, Eli Zaretskii wrote:
> On Thu, 30 Jun 2016 21:36:12 +0300, LRN wrote:
>> On 30.06.2016 20:42, Eli Zaretskii wrote:
>>> On Thu, 30 Jun 2016 20:18:52 +0300, LRN wrote:
>>>> I did. What did i do wrong? Had a single space (instead of two spaces)
>>>> after the name? Used "Fix PR gdb/14529" at the end instead of "PR
>>>> gdb/14529" at the beginning? No function name in parentheses (should
>>>> it have been signal_event_command?)?
>>>
>>> The latter.
>>>
>>
>> Fixed patches attached.
> 
> Thanks.  One last nit is that the ChangeLog entry for gdb.texinfo
> should also state a "function name", which is the node name where you
> made the changes.
> 

Fixed patch is attached.

Comments

LRN July 2, 2016, 1:16 a.m. UTC | #1 
On 30.06.2016 22:13, LRN wrote:
> On 30.06.2016 21:56, Eli Zaretskii wrote:
>> On Thu, 30 Jun 2016 21:36:12 +0300, LRN wrote:
>>> On 30.06.2016 20:42, Eli Zaretskii wrote:
>>>> On Thu, 30 Jun 2016 20:18:52 +0300, LRN wrote:
>>>>> I did. What did i do wrong? Had a single space (instead of two spaces)
>>>>> after the name? Used "Fix PR gdb/14529" at the end instead of "PR
>>>>> gdb/14529" at the beginning? No function name in parentheses (should
>>>>> it have been signal_event_command?)?
>>>>
>>>> The latter.
>>>>
>>>
>>> Fixed patches attached.
>>
>> Thanks.  One last nit is that the ChangeLog entry for gdb.texinfo
>> should also state a "function name", which is the node name where you
>> made the changes.
>>
> 
> Fixed patch is attached.
> 

So, anyway, is anything else expected of me? When should i expect to see
the patches pushed?

I also have a different patch that i want to submit. Should i do it now, in
a separate email, or wait until this one is through?
Eli Zaretskii July 2, 2016, 7:47 a.m. UTC | #2 
> From: LRN <lrn1986@gmail.com>
> Date: Sat, 2 Jul 2016 04:16:15 +0300
> 
> So, anyway, is anything else expected of me? When should i expect to see
> the patches pushed?

Please wait for a week, and if it doesn't get pushed, ping us here.

> I also have a different patch that i want to submit. Should i do it now, in
> a separate email, or wait until this one is through?

You could send it (with a separate Subject) right now, but since this
is your first submission to GDB, I suggest to wait for the previous
one to be pushed, in case there are some comments applicable to both
patches.

Thanks.
LRN July 10, 2016, 1:05 p.m. UTC | #3 
On 02.07.2016 10:47, Eli Zaretskii wrote:
> On 02.07.2016 4:16, LRN wrote:
>> So, anyway, is anything else expected of me? When should i expect to see
>> the patches pushed?
> 
> Please wait for a week, and if it doesn't get pushed, ping us here.

ping
Eli Zaretskii July 10, 2016, 2:54 p.m. UTC | #4 
> From: LRN <lrn1986@gmail.com>
> Date: Sun, 10 Jul 2016 16:05:56 +0300
> 
> On 02.07.2016 10:47, Eli Zaretskii wrote:
> > On 02.07.2016 4:16, LRN wrote:
> >> So, anyway, is anything else expected of me? When should i expect to see
> >> the patches pushed?
> > 
> > Please wait for a week, and if it doesn't get pushed, ping us here.
> 
> ping

Any objections to me pushing this to master?  Anyone?

Thanks.
LRN July 18, 2016, 10:08 a.m. UTC | #5 
On 10.07.2016 17:54, Eli Zaretskii wrote:
> On 10.07.2016 16:05, LRN wrote:
>> On 02.07.2016 10:47, Eli Zaretskii wrote:
>>> On 02.07.2016 4:16, LRN wrote:
>>>> So, anyway, is anything else expected of me? When should i expect to
>>>> see the patches pushed?
>>>
>>> Please wait for a week, and if it doesn't get pushed, ping us here.
>> 
>> ping
>> 
> 
> Any objections to me pushing this to master?  Anyone?
> 

ping
Eli Zaretskii July 19, 2016, 7:09 p.m. UTC | #6 
> From: LRN <lrn1986@gmail.com>
> Date: Mon, 18 Jul 2016 13:08:35 +0300
> 
> On 10.07.2016 17:54, Eli Zaretskii wrote:
> > On 10.07.2016 16:05, LRN wrote:
> >> On 02.07.2016 10:47, Eli Zaretskii wrote:
> >>> On 02.07.2016 4:16, LRN wrote:
> >>>> So, anyway, is anything else expected of me? When should i expect to
> >>>> see the patches pushed?
> >>>
> >>> Please wait for a week, and if it doesn't get pushed, ping us here.
> >> 
> >> ping
> >> 
> > 
> > Any objections to me pushing this to master?  Anyone?
> > 
> 
> ping

Sorry for the delay: life intervened big time.

If no one beats me to it, I will push this weekend.  Thank you for
your patience.

P.S. Do we really need a configure-time option?  Why not enable the
feature by default in the MinGW and Cygwin builds?
diff mbox

Patch

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e98a565..3822d2c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,12 @@ 
+2016-06-30  Руслан Ижбулатов  <lrn1986@gmail.com>
+
+	PR gdb/14529
+	* windows-nat.c (signal_event_command): New command
+        'signal-event' for W32 compatibility.
+	* gdb.texinfo (Cygwin Native): document the new 'signal-event'
+        command.
+	* NEWS: Add an entry about the new 'signal-event' command.
+
 2016-06-25  Tom Tromey  <tom@tromey.com>
 
 	* rust-lang.c (rust_get_disr_info, rust_print_type): Fix