mbox series

[PATCHv7,00/11] thread-specific breakpoints in just some inferiors

Message ID cover.1702507015.git.aburgess@redhat.com
Headers
Series thread-specific breakpoints in just some inferiors |

Message

Andrew Burgess Dec. 13, 2023, 10:38 p.m. UTC 
  In v7:

  - Addressed all the issues except one that Baris pointed out, this
    includes typos, some minor testsuite cleanups, and reformatting an
    assert (but not changing the meaning).

  - As requested, switched to use std::string_view in
    break-parse-cond.c file instead of a custom class, I agree that
    this is an improvement.

  - I've not changed the handling of -force-condition flag.  I replied
    to the review email with my thoughts, TLDR: fixing this would be a
    bigger task which I'd rather leave for ... the future.
    
  - Rebased and retested.

In v6:

  - Rebased to current master, one minor fix due to the C++17 changes,
    nothing major.  Retested.

In v5:

  - Updates after Lancelot's feedback, including, -force-condition can
    no longer be abbreviated to '-', and can't be used immediately
    after the breakpoint condition.

  - More tests to check some of the edge cases.

In v4:

  - Big update, this series now handles thread-specific and
    inferior-specific breakpoints.

In v3:

  - Rebased on to current upstream/master, this includes all Simon's
    recent breakpoint changes.  Retested with no regressions seen.

In v2:

  - Rebased on current upstream/master and retested,

  - No changes to code or docs.

---

Andrew Burgess (11):
  gdb: create_breakpoint: add asserts and additional comments
  gdb: create_breakpoint: asserts relating to extra_string/parse_extra
  gdb: change 'if' to gdb_assert in update_dprintf_command_list
  gdb: the extra_string in a dprintf breakpoint is never nullptr
  gdb: build dprintf commands just once in code_breakpoint constructor
  gdb: don't display inferior list for pending breakpoints
  gdb: parse pending breakpoint thread/task immediately
  gdb: don't set breakpoint::pspace for in create_breakpoint
  gdb: remove breakpoint_re_set_one
  gdb: remove tracepoint_probe_create_sals_from_location_spec
  gdb: only insert thread-specific breakpoints in the relevant inferior

 gdb/Makefile.in                               |   2 +
 gdb/NEWS                                      |  11 +
 gdb/ada-lang.c                                |   6 +-
 gdb/break-catch-throw.c                       |   6 +-
 gdb/break-cond-parse.c                        | 425 ++++++++++
 gdb/break-cond-parse.h                        |  49 ++
 gdb/breakpoint.c                              | 764 ++++++++----------
 gdb/breakpoint.h                              | 101 ++-
 gdb/testsuite/gdb.ada/tasks.exp               |   6 +-
 gdb/testsuite/gdb.base/condbreak.exp          |  57 +-
 gdb/testsuite/gdb.base/pending.exp            |  23 +-
 gdb/testsuite/gdb.linespec/explicit.exp       |   4 +-
 gdb/testsuite/gdb.mi/mi-dprintf-pending.exp   |   3 +-
 gdb/testsuite/gdb.mi/new-ui-bp-deleted.exp    |   8 +-
 .../gdb.mi/user-selected-context-sync.exp     |   4 +-
 .../gdb.multi/bp-thread-specific.exp          |   7 +-
 .../gdb.multi/inferior-specific-bp.exp        |  16 +-
 .../gdb.multi/multi-target-continue.exp       |   2 +-
 .../gdb.multi/multi-target-ping-pong-next.exp |   4 +-
 .../gdb.multi/pending-bp-del-inferior.c       |  28 +
 .../gdb.multi/pending-bp-del-inferior.exp     | 214 +++++
 gdb/testsuite/gdb.multi/pending-bp-lib.c      |  22 +
 gdb/testsuite/gdb.multi/pending-bp.c          |  66 ++
 gdb/testsuite/gdb.multi/pending-bp.exp        | 332 ++++++++
 gdb/testsuite/gdb.multi/tids.exp              |   6 +-
 .../gdb.threads/del-pending-thread-bp-lib.c   |  22 +
 .../gdb.threads/del-pending-thread-bp.c       |  85 ++
 .../gdb.threads/del-pending-thread-bp.exp     | 108 +++
 28 files changed, 1906 insertions(+), 475 deletions(-)
 create mode 100644 gdb/break-cond-parse.c
 create mode 100644 gdb/break-cond-parse.h
 create mode 100644 gdb/testsuite/gdb.multi/pending-bp-del-inferior.c
 create mode 100644 gdb/testsuite/gdb.multi/pending-bp-del-inferior.exp
 create mode 100644 gdb/testsuite/gdb.multi/pending-bp-lib.c
 create mode 100644 gdb/testsuite/gdb.multi/pending-bp.c
 create mode 100644 gdb/testsuite/gdb.multi/pending-bp.exp
 create mode 100644 gdb/testsuite/gdb.threads/del-pending-thread-bp-lib.c
 create mode 100644 gdb/testsuite/gdb.threads/del-pending-thread-bp.c
 create mode 100644 gdb/testsuite/gdb.threads/del-pending-thread-bp.exp


base-commit: 5c5e642dc0f6b223c2339d8dee64fbc63eee8e1a

Comments

Tom Tromey Dec. 15, 2023, 8:54 p.m. UTC | #1 
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> In v7:

Not a record but getting up there.

Anyway I read all the shorter patches and skimmed the longer ones.
I sent a few notes, but there's nothing serious and I think you should
move forward with it.

Thank you for doing this, I feel like its sort of a step toward
fine-grained breakpoint resetting as well.

Tom