mbox series

[v3,0/3] Make linux checkpoints work with multiple inferiors

Message ID 20240414195812.151224-1-kevinb@redhat.com
Headers
Series Make linux checkpoints work with multiple inferiors |

Message

Kevin Buettner April 14, 2024, 7:44 p.m. UTC 
  This series fixes some problems with the current checkpoint code.  The
first patch makes the checkpoint code inferior aware, fixing a number
of bugs.  The second and third patches are largely cosmetic - they
make changes to checkpoint related output.

The v2 series incorporates Pedro's suggestions regarding the
numbering of checkpoint ids.  See the first patch for details.  The
tests have been revised to account for these changes and new tests
have been added as well.

This v3 series splits out a cosmetic change from the first patch.
It capitalizes the output of a successful checkpoint command.
This was prompted by the Linaro regression tester, which, due to the
capitalization change, found two regressions in
gdb.base/kill-during-detach.exp.  (I thought I was running this test
during my own testing, but found that it was not being run due to a
typo in the TESTS= portion of the "make check" line.)

Kevin Buettner (3):
  Make linux checkpoints work with multiple inferiors
  Capitalize output of successful checkpoint command
  Make thread_db_target::pid_to_str checkpoint-aware

 gdb/linux-fork.c                              | 519 +++++++++----
 gdb/linux-fork.h                              |  15 +-
 gdb/linux-nat.c                               |  20 +-
 gdb/linux-thread-db.c                         |   4 +-
 gdb/testsuite/gdb.base/checkpoint.exp         |  26 +-
 gdb/testsuite/gdb.base/kill-during-detach.exp |   2 +-
 gdb/testsuite/gdb.multi/checkpoint-multi.exp  | 687 ++++++++++++++++++
 7 files changed, 1084 insertions(+), 189 deletions(-)
 create mode 100644 gdb/testsuite/gdb.multi/checkpoint-multi.exp

Comments

Kevin Buettner May 2, 2024, 1:49 a.m. UTC | #1 
Ping.

On Sun, 14 Apr 2024 12:44:41 -0700
Kevin Buettner <kevinb@redhat.com> wrote:

> This series fixes some problems with the current checkpoint code.  The
> first patch makes the checkpoint code inferior aware, fixing a number
> of bugs.  The second and third patches are largely cosmetic - they
> make changes to checkpoint related output.
> 
> The v2 series incorporates Pedro's suggestions regarding the
> numbering of checkpoint ids.  See the first patch for details.  The
> tests have been revised to account for these changes and new tests
> have been added as well.
> 
> This v3 series splits out a cosmetic change from the first patch.
> It capitalizes the output of a successful checkpoint command.
> This was prompted by the Linaro regression tester, which, due to the
> capitalization change, found two regressions in
> gdb.base/kill-during-detach.exp.  (I thought I was running this test
> during my own testing, but found that it was not being run due to a
> typo in the TESTS= portion of the "make check" line.)
> 
> Kevin Buettner (3):
>   Make linux checkpoints work with multiple inferiors
>   Capitalize output of successful checkpoint command
>   Make thread_db_target::pid_to_str checkpoint-aware
> 
>  gdb/linux-fork.c                              | 519 +++++++++----
>  gdb/linux-fork.h                              |  15 +-
>  gdb/linux-nat.c                               |  20 +-
>  gdb/linux-thread-db.c                         |   4 +-
>  gdb/testsuite/gdb.base/checkpoint.exp         |  26 +-
>  gdb/testsuite/gdb.base/kill-during-detach.exp |   2 +-
>  gdb/testsuite/gdb.multi/checkpoint-multi.exp  | 687 ++++++++++++++++++
>  7 files changed, 1084 insertions(+), 189 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.multi/checkpoint-multi.exp
> 
> -- 
> 2.44.0
>