mbox series

[0/3] Add amd64 LAM watchpoint support

Message ID 20240327074739.2969623-1-christina.schimpe@intel.com
Headers
Series Add amd64 LAM watchpoint support |

Message

Schimpe, Christina March 27, 2024, 7:47 a.m. UTC 
  Hi all,

This is a series to add watchpoint support with Liner Address Masking (LAM)
on amd64.

I am looking forward to your feedback!

Regards,
Christina

Christina Schimpe (3):
  gdb: Make tagged pointer support configurable.
  LAM: Enable tagged pointer support for watchpoints.
  LAM: Support kernel space debugging

 gdb/NEWS                             |  2 +
 gdb/aarch64-linux-nat.c              |  3 +-
 gdb/aarch64-linux-tdep.c             | 14 ++---
 gdb/aarch64-tdep.c                   | 12 +++--
 gdb/amd64-linux-tdep.c               | 80 ++++++++++++++++++++++++++++
 gdb/breakpoint.c                     |  4 +-
 gdb/gdbarch-gen.h                    | 50 +++++++++++++----
 gdb/gdbarch.c                        | 66 +++++++++++++++++++----
 gdb/gdbarch_components.py            | 54 ++++++++++++++++---
 gdb/target.c                         |  4 +-
 gdb/testsuite/gdb.arch/amd64-lam.c   | 49 +++++++++++++++++
 gdb/testsuite/gdb.arch/amd64-lam.exp | 45 ++++++++++++++++
 gdb/testsuite/lib/gdb.exp            | 62 +++++++++++++++++++++
 13 files changed, 401 insertions(+), 44 deletions(-)
 create mode 100755 gdb/testsuite/gdb.arch/amd64-lam.c
 create mode 100644 gdb/testsuite/gdb.arch/amd64-lam.exp

Comments

Schimpe, Christina April 15, 2024, 11:26 a.m. UTC | #1 
Kindly pinging for feedback.

The NEWS part is already approved by Eli.
I also got some feedback from Luis and will apply his comments regarding gdbarch function naming.
But I'd wait for further feedback until I push a v2 of this series.

Thanks, 
Christina

> Hi all,
> 
> This is a series to add watchpoint support with Liner Address Masking (LAM)
> on amd64.
> 
> I am looking forward to your feedback!
> 
> Regards,
> Christina
> 
> Christina Schimpe (3):
>   gdb: Make tagged pointer support configurable.
>   LAM: Enable tagged pointer support for watchpoints.
>   LAM: Support kernel space debugging
> 
>  gdb/NEWS                             |  2 +
>  gdb/aarch64-linux-nat.c              |  3 +-
>  gdb/aarch64-linux-tdep.c             | 14 ++---
>  gdb/aarch64-tdep.c                   | 12 +++--
>  gdb/amd64-linux-tdep.c               | 80 ++++++++++++++++++++++++++++
>  gdb/breakpoint.c                     |  4 +-
>  gdb/gdbarch-gen.h                    | 50 +++++++++++++----
>  gdb/gdbarch.c                        | 66 +++++++++++++++++++----
>  gdb/gdbarch_components.py            | 54 ++++++++++++++++---
>  gdb/target.c                         |  4 +-
>  gdb/testsuite/gdb.arch/amd64-lam.c   | 49 +++++++++++++++++
>  gdb/testsuite/gdb.arch/amd64-lam.exp | 45 ++++++++++++++++
>  gdb/testsuite/lib/gdb.exp            | 62 +++++++++++++++++++++
>  13 files changed, 401 insertions(+), 44 deletions(-)  create mode 100755
> gdb/testsuite/gdb.arch/amd64-lam.c
>  create mode 100644 gdb/testsuite/gdb.arch/amd64-lam.exp
> 
> --
> 2.34.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
Schimpe, Christina April 22, 2024, 7:17 a.m. UTC | #2 
Kindly pinging.

Regards,
Christina

> -----Original Message-----
> From: Schimpe, Christina
> Sent: Monday, April 15, 2024 1:26 PM
> To: gdb-patches@sourceware.org
> Cc: Eli Zaretskii <eliz@gnu.org>; Luis Machado <luis.machado@arm.com>
> Subject: RE: [PING][PATCH 0/3] Add amd64 LAM watchpoint support
> 
> Kindly pinging for feedback.
> 
> The NEWS part is already approved by Eli.
> I also got some feedback from Luis and will apply his comments regarding
> gdbarch function naming.
> But I'd wait for further feedback until I push a v2 of this series.
> 
> Thanks,
> Christina
> 
> > Hi all,
> >
> > This is a series to add watchpoint support with Liner Address Masking
> > (LAM) on amd64.
> >
> > I am looking forward to your feedback!
> >
> > Regards,
> > Christina
> >
> > Christina Schimpe (3):
> >   gdb: Make tagged pointer support configurable.
> >   LAM: Enable tagged pointer support for watchpoints.
> >   LAM: Support kernel space debugging
> >
> >  gdb/NEWS                             |  2 +
> >  gdb/aarch64-linux-nat.c              |  3 +-
> >  gdb/aarch64-linux-tdep.c             | 14 ++---
> >  gdb/aarch64-tdep.c                   | 12 +++--
> >  gdb/amd64-linux-tdep.c               | 80 ++++++++++++++++++++++++++++
> >  gdb/breakpoint.c                     |  4 +-
> >  gdb/gdbarch-gen.h                    | 50 +++++++++++++----
> >  gdb/gdbarch.c                        | 66 +++++++++++++++++++----
> >  gdb/gdbarch_components.py            | 54 ++++++++++++++++---
> >  gdb/target.c                         |  4 +-
> >  gdb/testsuite/gdb.arch/amd64-lam.c   | 49 +++++++++++++++++
> >  gdb/testsuite/gdb.arch/amd64-lam.exp | 45 ++++++++++++++++
> >  gdb/testsuite/lib/gdb.exp            | 62 +++++++++++++++++++++
> >  13 files changed, 401 insertions(+), 44 deletions(-)  create mode
> > 100755 gdb/testsuite/gdb.arch/amd64-lam.c
> >  create mode 100644 gdb/testsuite/gdb.arch/amd64-lam.exp
> >
> > --
> > 2.34.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928