mbox series

[v5,0/3] Dynamic properties of pointers

Message ID 20240115131654.19374-1-abdul.b.ijaz@intel.com
Headers
Series Dynamic properties of pointers |

Message

Abdul Basit Ijaz Jan. 15, 2024, 1:16 p.m. UTC 
  From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>

Hi!

Please find the attached v5 of this series where it contains only the
fixes according to the latest feedback on V4 series.

V4 can be found here:
https://sourceware.org/pipermail/gdb-patches/2024-January/205661.html

V3 can be found here:
https://sourceware.org/pipermail/gdb-patches/2023-September/202143.html

V2 patch 2 was approved by Tom already in this discussion but there are
minor changes since then:
https://sourceware.org/pipermail/gdb-patches/2023-January/195353.html

V2 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-October/192389.html

V1 with feedback can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-September/191934.html

Changes since v4:

  * Patch 1:
  Identation changes as per Tom feedback.

  * Patch 2:
  Fix Tom feedback related to pointer or reference case handling to
  include TYPE_CODE_RVALUE_REF also.

Following test configurations are tested on Ubuntu22.04 and no
regression is seen:
gcc64/gcc32/native-gdbserver/native-extended-gdbserver(-m32)

I'm looking forward to comments.

Thanks & Best Regards,
Abdul Basit

Bernhard Heckel (1):
  gdb, types: Resolve pointer types dynamically

Ijaz, Abdul B (1):
  gdb/testsuite: Fix indentation issues in gdb.dwarf2/dynarr-ptr.exp

Nils-Christian Kempke (1):
  gdb, testsuite, fortran: Fix sizeof intrinsic for Fortran pointers

 gdb/eval.c                                    |   7 +
 gdb/gdbtypes.c                                |   7 +-
 gdb/testsuite/gdb.cp/vla-cxx.cc               |   4 +
 gdb/testsuite/gdb.cp/vla-cxx.exp              |  15 ++
 gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp       | 136 +++++++++---------
 .../gdb.fortran/pointer-to-pointer.exp        |   2 +-
 gdb/testsuite/gdb.fortran/pointers.exp        | 115 +++++++++++++++
 gdb/testsuite/gdb.fortran/pointers.f90        |  29 ++++
 gdb/testsuite/gdb.fortran/sizeof.exp          | 115 +++++++++++++++
 gdb/testsuite/gdb.fortran/sizeof.f90          | 108 ++++++++++++++
 gdb/valprint.c                                |   6 -
 11 files changed, 467 insertions(+), 77 deletions(-)
 create mode 100644 gdb/testsuite/gdb.fortran/pointers.exp
 create mode 100644 gdb/testsuite/gdb.fortran/sizeof.exp
 create mode 100644 gdb/testsuite/gdb.fortran/sizeof.f90

Comments

Tom Tromey Feb. 1, 2024, 12:36 a.m. UTC | #1 
>>>>> Abdul Basit Ijaz <abdul.b.ijaz@intel.com> writes:

> From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>
> Hi!

> Please find the attached v5 of this series where it contains only the
> fixes according to the latest feedback on V4 series.

Thank you.  I sent one nit, but this looks good with that fixed.

Approved-By: Tom Tromey <tom@tromey.com>

Tom