mbox series

[0/2] Change all E_MIPS_* to EF_MIPS_*

Message ID 20231114094535.434194-1-ying.huang@oss.cipunited.com
Headers
Series Change all E_MIPS_* to EF_MIPS_* |

Message

Ying Huang Nov. 14, 2023, 9:45 a.m. UTC 
  According to we have changed all E_MIPS_* to EF_MIPS_* in binutils
and glibc, we also need to change it here to keep same style.
We can refer to this commit record:
https://sourceware.org/pipermail/binutils/2023-October/129904.html

Comments

Pedro Alves Nov. 14, 2023, 11:43 a.m. UTC | #1 
On 2023-11-14 09:45, Ying Huang wrote:
> According to we have changed all E_MIPS_* to EF_MIPS_* in binutils
> and glibc, we also need to change it here to keep same style.
> We can refer to this commit record:
> https://sourceware.org/pipermail/binutils/2023-October/129904.html

This is OK, but please put this information in the commit logs themselves, so that
if someone in the future needs to "git blame" the touched lines isn't left with
an empty rationale for the change.

So, you can add my:

 Approved-By: Pedro Alves <pedro@palves.net>

with that change.
Ying Huang Nov. 15, 2023, 2:19 a.m. UTC | #2 
Hi Pedro,

在 2023/11/14 19:43, Pedro Alves 写道:
> On 2023-11-14 09:45, Ying Huang wrote:
>> According to we have changed all E_MIPS_* to EF_MIPS_* in binutils
>> and glibc, we also need to change it here to keep same style.
>> We can refer to this commit record:
>> https://sourceware.org/pipermail/binutils/2023-October/129904.html
> This is OK, but please put this information in the commit logs themselves, so that
> if someone in the future needs to "git blame" the touched lines isn't left with
> an empty rationale for the change.
>
> So, you can add my:
>
>  Approved-By: Pedro Alves <pedro@palves.net>
>
> with that change.
>
OK, I would send patch V2 with commit message.

Thanks,

Ying
YunQiang Su Nov. 16, 2023, 2:25 a.m. UTC | #3 
On Tue, Nov 14, 2023 at 11:43:27AM +0000, Pedro Alves wrote:
> On 2023-11-14 09:45, Ying Huang wrote:
> > According to we have changed all E_MIPS_* to EF_MIPS_* in binutils
> > and glibc, we also need to change it here to keep same style.
> > We can refer to this commit record:
> > https://sourceware.org/pipermail/binutils/2023-October/129904.html
> 
> This is OK, but please put this information in the commit logs themselves, so that
> if someone in the future needs to "git blame" the touched lines isn't left with
> an empty rationale for the change.
> 
> So, you can add my:
> 
>  Approved-By: Pedro Alves <pedro@palves.net>
> 
> with that change.
>

Thank you. I have pushed Ying's v2 patchset.