mbox series

[0/5] Adjust/fix gdb.thread/pthreads.exp for Cygwin

Message ID 20230920175959.2305271-1-pedro@palves.net
Headers
Series Adjust/fix gdb.thread/pthreads.exp for Cygwin |

Message

Pedro Alves Sept. 20, 2023, 5:59 p.m. UTC 
  This set of patches improves gdb.thread/pthreads.exp when testing
against Cygwin.  The test still won't pass cleanly [1] without some GDB
fixes (which I plan on submitting later at some point), but if you run
it against the GDB distributed with Cygwin, at least, it passes (they
have some local GDB patches missing upstream).

[1] - it fails with:

 FAIL: gdb.threads/pthreads.exp: Stopped with a ^C (timeout)
 WARNING: Could not stop child with ^C; skipping rest of tests.

Pedro Alves (5):
  gdb.threads/pthreads.c, K&R -> ANSI function style
  Fix gdb.threads/pthreads.c formatting
  Fix gdb.threads/pthreads.exp error handling/printing
  In gdb.threads/pthreads.c, handle pthread_attr_setscope ENOTSUP
  Adjust gdb.thread/pthreads.exp for Cygwin

 gdb/testsuite/gdb.threads/pthreads.c   | 86 ++++++++++++++++----------
 gdb/testsuite/gdb.threads/pthreads.exp | 14 ++---
 2 files changed, 60 insertions(+), 40 deletions(-)


base-commit: 093da43d2adb4497dfec8afbb4eeaf2425668fdd

Comments

Tom Tromey Sept. 21, 2023, 7:21 p.m. UTC | #1 
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:

Pedro> This set of patches improves gdb.thread/pthreads.exp when testing
Pedro> against Cygwin.  The test still won't pass cleanly [1] without some GDB
Pedro> fixes (which I plan on submitting later at some point), but if you run
Pedro> it against the GDB distributed with Cygwin, at least, it passes (they
Pedro> have some local GDB patches missing upstream).

This all seems fine to me.  Thank you.
Approved-By: Tom Tromey <tom@tromey.com>

Tom